From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: patch for conntrack expectations Date: Thu, 04 Mar 2004 00:52:38 +0100 Sender: netfilter-devel-admin@lists.netfilter.org Message-ID: <40466FC6.50304@trash.net> References: <403014C5.8080102@eurodev.net> <20040217213217.GF30968@obroa-skai.de.gnumonks.org> <4032F4DE.3050402@eurodev.net> <20040218172539.GX9464@sunbeam.de.gnumonks.org> <4038B14C.901@eurodev.net> <20040224094014.GV13386@sunbeam.de.gnumonks.org> <403B1F5F.6010004@trash.net> <20040224102432.GX13386@sunbeam.de.gnumonks.org> <403B7CAA.3060005@trash.net> <403CD128.40101@eurodev.net> <404668EB.1080400@trash.net> <40466C6C.6010301@eurodev.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org Return-path: To: Pablo Neira In-Reply-To: <40466C6C.6010301@eurodev.net> Errors-To: netfilter-devel-admin@lists.netfilter.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: netfilter-devel.vger.kernel.org Pablo Neira wrote: > Hi Patrick, > > Patrick McHardy wrote: > >> One thing that >> seems to affect all changed helpers, you return -ENOMEM when >> ip_conntrack_expect_alloc() fails > > > actually i was thinking about this issue today, since I also posted in a > recent email (please see: comments about ip_conntrack_in) that i didn't > find a helper which returns -1, then I realized that my patch returned > -ENOMEM. Sorry, I'm not entirely up-to-date with my mails as you can see from my late comments ;) I'll read up on it now. > > I'll submit a new patch tomorrow. Thanks. Regards, Patrick > > Thanks, > Pablo >