From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Subject: Re: patch for conntrack expectations Date: Thu, 04 Mar 2004 01:10:23 +0100 Sender: netfilter-devel-admin@lists.netfilter.org Message-ID: <404673EF.7030207@eurodev.net> References: <403014C5.8080102@eurodev.net> <20040217213217.GF30968@obroa-skai.de.gnumonks.org> <4032F4DE.3050402@eurodev.net> <20040218172539.GX9464@sunbeam.de.gnumonks.org> <4038B14C.901@eurodev.net> <20040224094014.GV13386@sunbeam.de.gnumonks.org> <403B1F5F.6010004@trash.net> <20040224102432.GX13386@sunbeam.de.gnumonks.org> <403B7CAA.3060005@trash.net> <403CD128.40101@eurodev.net> <404668EB.1080400@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: To: Patrick McHardy , netfilter-devel@lists.netfilter.org In-Reply-To: <404668EB.1080400@trash.net> Errors-To: netfilter-devel-admin@lists.netfilter.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: netfilter-devel.vger.kernel.org Hi Patrick, Patrick McHardy wrote: > Hi Pablo, > this patch is not correct as far as I can see. With your new API, > ip_contrack_expect_related owns the memory after beeing called. > The cleaned up amanda helper reuses the same memory for all > expectations and expects ip_conntrack_expect_related to allocate > new memory and copy the data, so this will result in corruption. > It also leaks memory if the loop is left early. oops, i'm sorry, I didn't realize that the structure of the amanda helper changed a bit. Yes, my patch for the amanda helper sucks a bit !:-). I know how to fix it, I'll submit the patch tomorrow. thanks, Pablo