Re: Linux 2.4.26-pre2

[Michal Schmidt <xschmi00@stud.feec.vutbr.cz>]

Hello,

> <mlord:pobox.com>:
>   o Fix vmalloc() error handling
> 

This change has a problem. In __vmalloc_area_pages when pmd_alloc fails, 
the spinlock will not be released. Maybe the following patch is needed? 
(only compile tested, I don't have SMP)

Michal Schmidt


--- linux-2.4.26-pre2/mm/vmalloc.c      Sun Mar  7 20:44:27 2004
+++ linux-2.4.26-pre2.mich/mm/vmalloc.c Sun Mar  7 20:54:02 2004
@@ -183,6 +183,7 @@ static inline int __vmalloc_area_pages (
  err:
         if (address > start)
                 vmfree_area_pages((address - start), address - start);
+       spin_unlock(&init_mm.page_table_lock);
         return -ENOMEM;
  }