Re: [PATCH] datalen variable unused in ftp helper.

[Patrick McHardy <kaber@trash.net>]

Pablo Neira wrote:
> Hi Patrick,
> 
> Patrick McHardy wrote:
> 
>>> --- linux-2.6.3/net/ipv4/netfilter/ip_conntrack_ftp.c    2004-03-09 
>>> 18:49:21.000000000 +0100
>>> +++ linux-2.6.3-old/net/ipv4/netfilter/ip_conntrack_ftp.c    
>>> 2004-02-18 04:59:06.000000000 +0100
>>> @@ -281,7 +281,7 @@
>>>      datalen = skb->len - dataoff;
>>
>>
>>
>> ^^ Shouldn't the patch remove the variable entirely then ?
> 
> 
> 
> I'm not sure what's better. Adding a new parameter to the stack is cheap 
> and this way I'm sure that gcc won't generate code to calculate skb->len 
> - dataoff over and over again. I'm not a compiler geek, so I could be 
> wrong :-). If you think that removing datalen is a better solution, 
> please let me know and I'll post the patch.

No I don't think so, I was confused by your patch which is reversed,
so I thought you wanted to remove the variable. It is used quite often,
so that doesn't make much sense. In the right order, your patch is
fine ;)

Regards
Patrick

> 
> regards,
> Pablo
>