All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Schwaighofer <cs@tequila.co.jp>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ppc64: Fix occasional crash at boot in OF interface
Date: Wed, 10 Mar 2004 14:18:11 +0900	[thread overview]
Message-ID: <404EA513.5060703@tequila.co.jp> (raw)
In-Reply-To: <1078890877.9750.52.camel@gaston>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Benjamin Herrenschmidt wrote:

is there a reason why you dropped all the comments ?

eg:

- -	REST_GPR(2, r1)			/* Restore the TOC */
- -	REST_GPR(13, r1)		/* Restore paca */
- -	REST_8GPRS(14, r1)		/* Restore the non-volatiles */
- -	REST_10GPRS(22, r1)		/* ditto */
- -
+	/* Restore other registers */
+	REST_GPR(2, r1)
+	REST_GPR(13, r1)
+	REST_8GPRS(14, r1)
+	REST_10GPRS(22, r1)

- --
Clemens Schwaighofer - IT Engineer & System Administration
==========================================================
Tequila Japan, 6-17-2 Ginza Chuo-ku, Tokyo 104-8167, JAPAN
Tel: +81-(0)3-3545-7703            Fax: +81-(0)3-3545-7343
http://www.tequila.jp
==========================================================
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFATqUSjBz/yQjBxz8RAqJyAJ9hRRsZleuPlZJ/LOqOtGVZDqkR/ACg7EjY
P88/EX+cR3/OkcH980/pC2M=
=TDWR
-----END PGP SIGNATURE-----

  reply	other threads:[~2004-03-10  5:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-10  3:54 [PATCH] ppc64: Fix occasional crash at boot in OF interface Benjamin Herrenschmidt
2004-03-10  5:18 ` Clemens Schwaighofer [this message]
2004-03-10  5:29   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=404EA513.5060703@tequila.co.jp \
    --to=cs@tequila.co.jp \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.