From: Rene Herman <rene.herman@keyaccess.nl>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [TRIVIAL] 8139too assertions
Date: Wed, 10 Mar 2004 23:49:15 +0100 [thread overview]
Message-ID: <404F9B6B.10102@keyaccess.nl> (raw)
[-- Attachment #1: Type: text/plain, Size: 142 bytes --]
Hi Jeff,
current placements of these asserts seems unhelpful; we've already oopsed.
Incremental to IFG patch only for line-numbers.
Rene.
[-- Attachment #2: linux-2.6.4-rc2-mm1_8139too-assert.diff --]
[-- Type: text/plain, Size: 469 bytes --]
--- linux-2.6.4-rc2-mm1/drivers/net/8139too.c~ 2004-03-10 22:58:52.000000000 +0100
+++ linux-2.6.4-rc2-mm1/drivers/net/8139too.c 2004-03-10 23:00:49.000000000 +0100
@@ -974,12 +974,11 @@
if (i < 0)
return i;
+ assert (dev != NULL);
tp = dev->priv;
+ assert (tp != NULL);
ioaddr = tp->mmio_addr;
-
assert (ioaddr != NULL);
- assert (dev != NULL);
- assert (tp != NULL);
addr_len = read_eeprom (ioaddr, 0, 8) == 0x8129 ? 8 : 6;
for (i = 0; i < 3; i++)
next reply other threads:[~2004-03-10 22:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-10 22:49 Rene Herman [this message]
2004-03-12 18:40 ` [TRIVIAL] 8139too assertions Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404F9B6B.10102@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.