grub2 bug and question

grub2 bug and question

[Sergey Matveychuk]

Hello.

I've begun work with grub2 sources. There is some progress.

I've found a bug:
util/pupa-emu.c:main() - grub2 can't guess a root device because 
pupa_guess_root_device() called before pupa_util_biosdisk_init().

pupa_guess_root_device() use map[] before it's filled in 
pupa_util_biosdisk_init().

Question: it's looks like a root command get only disk name (root (hd0)) 
and don't understand old syntax: root (hd0,1,a)?

---
Sem.

Re: grub2 bug and question

[M. Gerards]

Quoting Sergey Matveychuk <sem@ciam.ru>:

> Hello.
> 
> I've begun work with grub2 sources. There is some progress.
> 
> I've found a bug:
> util/pupa-emu.c:main() - grub2 can't guess a root device because 
> pupa_guess_root_device() called before pupa_util_biosdisk_init().
> 
> pupa_guess_root_device() use map[] before it's filled in 
> pupa_util_biosdisk_init().


Thanks for the report.  I will have a look at this problem in the weekend.
Can you descibe how I can reproduce your problem?

> Question: it's looks like a root command get only disk name (root (hd0)) 
> and don't understand old syntax: root (hd0,1,a)?

My guess is that no one worked on BSD support.  There is something there, but I
am not sure if it is tested.

The root command will be removed and variables will be used instead.  For 
example:

root=(hd0,1)

--
Marco

Re: grub2 bug and question

[Sergey Matveychuk]

Hi, Marco!

M. Gerards wrote:
> Thanks for the report.  I will have a look at this problem in the weekend.
> Can you descibe how I can reproduce your problem?

I'm waiting for your "normal mode patch" to confirm this problem if it 
will be staied there.

-- 
Sem.

Re: grub2 bug and question

[Marco Gerards]

Sergey Matveychuk <sem@ciam.ru> writes:

Hi Sergey,

> M. Gerards wrote:
>> Thanks for the report.  I will have a look at this problem in the weekend.
>> Can you descibe how I can reproduce your problem?
>
> I'm waiting for your "normal mode patch" to confirm this problem if it
> will be staied there.

Okuji told me it would be ok to check this patch in.  I am quite busy
this week so I did not have the time to have a look at the patch, make
one required modification and commit it.

Hopefully I will commit the patch this evening, otherwise it will be
tomorrow evening.

--
Marco