From: Stefan Smietanowski <stesmi@stesmi.com>
To: Andreas Schwab <schwab@suse.de>
Cc: "Måns Rullgård" <mru@kth.se>, linux-kernel@vger.kernel.org
Subject: Re: (0 == foo), rather than (foo == 0)
Date: Thu, 11 Mar 2004 18:42:30 +0100 [thread overview]
Message-ID: <4050A506.3000703@stesmi.com> (raw)
In-Reply-To: <je4qsvs98a.fsf@sykes.suse.de>
Hi Andreas.
>>>>The warning should be there whether there are parenthesis or not,
>>>>and it should state that you should have an explicit inequality
>>>>expression. So if you have
>>>> if (a = b) ...
>>>>and you really _mean_ that, then the way to write it sanely is to
>>>>just write it as
>>>> if ((a = b) != 0)
>>>> ...
>>>>which makes it much clearer what you're actually doing.
>>>
>>>Or actually change it to
>>>
>>>a = b;
>>>if (a)
>>
>>That doesn't work with while().
>
>
> But this works: while (a = b, a != 0).
> (not that it is any better readable :-) ).
My eyes! *Starts clawing them out*
// Stefan
next prev parent reply other threads:[~2004-03-11 17:42 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-10 6:16 (0 == foo), rather than (foo == 0) Godbole, Amarendra (GE Consumer & Industrial)
2004-03-10 10:34 ` Bernd Petrovitsch
2004-03-10 18:02 ` Randy.Dunlap
2004-03-10 18:33 ` Richard B. Johnson
2004-03-10 18:50 ` [OT] " David Ford
2004-03-10 19:06 ` Roland Dreier
2004-03-10 19:26 ` David Ford
2004-03-10 21:26 ` Roland Dreier
2004-03-10 22:03 ` Måns Rullgård
2004-03-11 23:12 ` Bill Davidsen
2004-03-10 19:23 ` Richard B. Johnson
2004-03-10 19:31 ` David Ford
2004-03-10 23:20 ` Frank v Waveren
2004-03-10 23:33 ` Måns Rullgård
2004-03-11 2:14 ` David Ford
2004-03-11 15:06 ` Valdis.Kletnieks
2004-03-10 23:10 ` Peter Williams
2004-03-10 21:29 ` viro
2004-03-10 22:20 ` David Ford
2004-03-10 22:42 ` Richard B. Johnson
2004-03-11 0:33 ` Micha Feigin
2004-03-11 10:47 ` Giuseppe Bilotta
2004-03-10 22:49 ` Stefan Smietanowski
2004-03-10 23:14 ` David Ford
2004-03-10 23:28 ` Måns Rullgård
2004-03-10 23:47 ` Stefan Smietanowski
2004-03-10 21:34 ` Matthew Garrett
2004-03-10 23:00 ` Peter Williams
2004-03-11 0:16 ` Randy.Dunlap
2004-03-11 2:36 ` Linus Torvalds
2004-03-11 3:08 ` Peter Williams
2004-03-11 3:19 ` Linus Torvalds
2004-03-11 4:40 ` Stefan Smietanowski
2004-03-11 9:48 ` Måns Rullgård
2004-03-11 10:29 ` Stefan Smietanowski
2004-03-11 15:18 ` Andreas Schwab
2004-03-11 17:42 ` Stefan Smietanowski [this message]
2004-03-11 23:05 ` Bill Davidsen
2004-03-11 6:50 ` Willy Tarreau
2004-03-11 7:36 ` Peter Williams
2004-03-11 15:03 ` Valdis.Kletnieks
2004-03-11 15:22 ` Richard B. Johnson
2004-03-11 15:48 ` Valdis.Kletnieks
-- strict thread matches above, loose matches on Subject: below --
2004-03-11 4:04 Godbole, Amarendra (GE Consumer & Industrial)
[not found] <1y5oc-8cr-1@gated-at.bofh.it>
[not found] ` <1ygjH-3LE-31@gated-at.bofh.it>
[not found] ` <1ygMH-4eu-21@gated-at.bofh.it>
[not found] ` <1yzZ9-1qq-43@gated-at.bofh.it>
[not found] ` <1yAs0-1P6-7@gated-at.bofh.it>
[not found] ` <1yALu-288-5@gated-at.bofh.it>
2004-03-11 16:41 ` Chip Salzenberg
[not found] <1ypPV-5N2-3@gated-at.bofh.it>
2004-03-11 16:44 ` Chip Salzenberg
2004-03-11 23:57 ` Peter Williams
2004-03-12 1:51 ` Chris Johns
2004-03-12 12:21 ` Richard B. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4050A506.3000703@stesmi.com \
--to=stesmi@stesmi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mru@kth.se \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.