From: Pierre AUBERT <p.aubert@staubli.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] PATCH - add CMD_BMP and SPLASH_SCREEN support in cfb_console
Date: Mon, 15 Mar 2004 10:02:01 +0100 [thread overview]
Message-ID: <40557109.1070509@staubli.com> (raw)
In-Reply-To: <20040314165811.3C1A6C0655@atlas.denx.de>
Hi Wolfgang
Wolfgang Denk wrote:
>In message <40509BDC.6060506@staubli.com> you wrote:
>
>
>>The attached patch add bitmap (8bpp and 24bpp) support on cfb_console.
>>
>>
>
>It also does some other things which you don't bother to mention
>here.
>
>Please ALWAYS describe ALL extensions to the code.
>
>
>
>>Be carefull: this patch moves the environment location in flash for the
>>Lite5200 board.
>>U-boot room became too small ...
>>
>>
>
>Thanks for the warning, but actually I would like to ask you to SPLIT
>such modifications into separate, independend patches.
>
>
>Also, it is not exactly nice to enable non-standard features (like
>CONFIG_VIDEO or CONFIG_CFB_CONSOLE, CFG_CMD_BMP) while deleting
>
>
Sorry, I've enabled this config for testing purpose and I've forgotten
to remove it.
>others (CONFIG_DOS_PARTITION) in public configuration files
>(IceCube.h).
>
>
I've deleted CONFIG_DOS_PARTITION because it's defined twice in
Icecube.h !!!
(and it's always defined twice in the CVS ...)
>
>
>
>Best regards,
>
>Wolfgang Denk
>
>
>
Best regards
next prev parent reply other threads:[~2004-03-15 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-11 17:03 [U-Boot-Users] PATCH - add CMD_BMP and SPLASH_SCREEN support in cfb_console Pierre AUBERT
2004-03-14 16:58 ` Wolfgang Denk
2004-03-15 9:02 ` Pierre AUBERT [this message]
2004-03-15 9:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40557109.1070509@staubli.com \
--to=p.aubert@staubli.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.