From: Jeff Garzik <jgarzik@pobox.com>
To: "Steven J. Hill" <Steve.Hill@timesys.com>
Cc: Netdev <netdev@oss.sgi.com>, Tim Hockin <thockin@sun.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
ralf@linux-mips.org
Subject: Re: [PATCH] fix natsemi PCI mapping
Date: Tue, 16 Mar 2004 14:20:20 -0500 [thread overview]
Message-ID: <40575374.6080006@pobox.com> (raw)
In-Reply-To: <4057525E.6020205@timesys.com>
Steven J. Hill wrote:
> Jeff Garzik wrote:
>
>>
>> Somebody wanna review and/or test?
>>
> Hey Jeff.
>
> I have tested this on 2.4 and it works great on MIPS with one
> minor change below. Remove the 16 byte alignment of the IP
> header. I discovered this when trying to do a BOOTP and mount
> my NFS root filesystem. The BOOTP never succeeds. Patch against
> latest 2.4.25 attached.
Interesting, thanks.
WRT skb_reserve(), I wonder if
(a) RX_OFFSET value passed to skb_reserve() needs to be per-arch
(b) the pre-existing skb_reserve() call is wrong too
prev parent reply other threads:[~2004-03-16 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-16 18:06 [PATCH] fix natsemi PCI mapping Jeff Garzik
2004-03-16 19:15 ` Steven J. Hill
2004-03-16 19:20 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40575374.6080006@pobox.com \
--to=jgarzik@pobox.com \
--cc=Steve.Hill@timesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=ralf@linux-mips.org \
--cc=thockin@sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.