[PATCH] SEGV in libsysfs/dlist.c

[Hannes Reinecke <hare@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi all, Greg,

libsysfs/dlist.c: _dlist_mark_move()

is missing checks for empty lists and may (and indeed, does) crash when 
called with empty dlists.

Please apply.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux AG				S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[-- Attachment #2: libsysfs-dlist.patch --]
[-- Type: text/plain, Size: 503 bytes --]

===== dlist.c 1.3 vs edited =====
--- 1.3/libsysfs/dlist.c	Wed Mar 10 18:12:14 2004
+++ edited/dlist.c	Thu Mar 18 13:11:00 2004
@@ -74,14 +74,14 @@
 {
   if(direction)
     {
-      if( list->marker->next!=NULL)
+      if( list->marker && list->marker->next!=NULL)
 	list->marker=list->marker->next;
       else
 	return(NULL);
     }
   else
     {
-      if( list->marker->prev!=NULL)
+      if( list->marker && list->marker->prev!=NULL)
 	list->marker=list->marker->prev;
       else
 	return(NULL);