From: Viktor Radnai <efti@gotiao.com>
To: Dominik Brodowski <linux@dominikbrodowski.de>, cpufreq@www.linux.org.uk
Subject: Re: [PATCH 2.6.4] (2/5) p4-clockmod: single-line KERN_WARNING messages
Date: Sun, 21 Mar 2004 15:25:50 +1100 [thread overview]
Message-ID: <405D194E.8070600@gotiao.com> (raw)
In-Reply-To: <20040315141453.GC8636@dominikbrodowski.de>
Hi all,
It seems that there's a slight gramatical error in this patch. The
second message says:
> + printk(KERN_WARNING PFX "Warning: Pentium 4-M detected. "
> + "The speedstep-ich or acpi cpufreq modules offers "
> + "voltage scaling in addition of frequency scaling. "
> + "You should use either one instead of p4-clockmod, "
> + "if possible.\n");
It should say "offer" instead of "offers":
+ "The speedstep-ich or acpi cpufreq modules offer "
Apologies if this is considered nitpicking...
Regards,
Vik
Dominik Brodowski wrote:
> Use KERN_WARNING for warning. Thanks to Dave Jones, Pavel Machel and Russell
> King for their help getting this patch right.
>
> arch/i386/kernel/cpu/cpufreq/p4-clockmod.c | 17 ++++++++++-------
> 1 files changed, 10 insertions(+), 7 deletions(-)
>
> diff -ruN linux-original/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c linux/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c
> --- linux-original/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c 2004-03-15 09:20:50.000000000 +0100
> +++ linux/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c 2004-03-15 13:28:00.997133712 +0100
> @@ -181,21 +181,24 @@
> {
> if ((c->x86 == 0x06) && (c->x86_model == 0x09)) {
> /* Pentium M */
> - printk(KERN_DEBUG PFX "Warning: Pentium M detected. The speedstep_centrino module\n");
> - printk(KERN_DEBUG PFX "offers voltage scaling in addition of frequency scaling. You\n");
> - printk(KERN_DEBUG PFX "should use that instead of p4-clockmod, if possible.\n");
> + printk(KERN_WARNING PFX "Warning: Pentium M detected. "
> + "The speedstep_centrino module offers voltage scaling"
> + " in addition of frequency scaling. You should use "
> + "that instead of p4-clockmod, if possible.\n");
> return speedstep_get_processor_frequency(SPEEDSTEP_PROCESSOR_PM);
> }
>
> if (c->x86 != 0xF) {
> - printk(KERN_DEBUG PFX "Unknown p4-clockmod-capable CPU. Please send an e-mail to <linux@brodo.de>\n");
> + printk(KERN_WARNING PFX "Unknown p4-clockmod-capable CPU. Please send an e-mail to <linux@brodo.de>\n");
> return 0;
> }
>
> if (speedstep_detect_processor() == SPEEDSTEP_PROCESSOR_P4M) {
> - printk(KERN_DEBUG PFX "Warning: Pentium 4-M detected. The speedstep-ich or acpi cpufreq \n");
> - printk(KERN_DEBUG PFX "modules offers voltage scaling in addition of frequency scaling. You\n");
> - printk(KERN_DEBUG PFX "should use either one instead of p4-clockmod, if possible.\n");
> + printk(KERN_WARNING PFX "Warning: Pentium 4-M detected. "
> + "The speedstep-ich or acpi cpufreq modules offers "
> + "voltage scaling in addition of frequency scaling. "
> + "You should use either one instead of p4-clockmod, "
> + "if possible.\n");
> return speedstep_get_processor_frequency(SPEEDSTEP_PROCESSOR_P4M);
> }
>
>
> _______________________________________________
> Cpufreq mailing list
> Cpufreq@www.linux.org.uk
> http://www.linux.org.uk/mailman/listinfo/cpufreq
>
prev parent reply other threads:[~2004-03-21 4:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 14:14 [PATCH 2.6.4] (2/5) p4-clockmod: single-line KERN_WARNING messages Dominik Brodowski
2004-03-21 4:25 ` Viktor Radnai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405D194E.8070600@gotiao.com \
--to=efti@gotiao.com \
--cc=cpufreq@www.linux.org.uk \
--cc=linux@dominikbrodowski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.