From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/2] examples: add missing newline at eof
Date: Sun, 27 Feb 2022 23:35:52 +0100 [thread overview]
Message-ID: <4062580.yKVeVyVuyW@thomas> (raw)
In-Reply-To: <20220227133207.3c3a53fe@hermes.local>
27/02/2022 22:32, Stephen Hemminger:
> On Sun, 27 Feb 2022 21:27:40 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > 25/02/2022 18:47, Stephen Hemminger:
> > > The text file did not end with newline.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > Series applied, thanks for the cleanup.
> >
> > Could we add a check in checkpatch to avoid it in future?
>
> The only tool I saw to find these was
> pcregrep -LMr '\n\Z'
>
> But probably possible with a complex python one-liner...
It can be done with diff:
diff /dev/null $file | tail -1 | grep '^\\ No newline'
prev parent reply other threads:[~2022-02-27 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 17:47 [PATCH 1/2] remove extra blank line at eof Stephen Hemminger
2022-02-25 17:47 ` [PATCH 2/2] examples: add missing newline " Stephen Hemminger
2022-02-27 20:27 ` Thomas Monjalon
2022-02-27 21:32 ` Stephen Hemminger
2022-02-27 22:35 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4062580.yKVeVyVuyW@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.