From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jjM8F-00073c-4c for mharc-grub-devel@gnu.org; Thu, 11 Jun 2020 08:16:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjM8D-00073O-Ag for grub-devel@gnu.org; Thu, 11 Jun 2020 08:16:29 -0400 Received: from mout.gmx.net ([212.227.17.20]:53525) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjM8C-0000sb-68 for grub-devel@gnu.org; Thu, 11 Jun 2020 08:16:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1591877786; bh=TNg1G5CURYq9i6DwPKM/Mi7P8jgGF042nFbEHM2jfFo=; h=X-UI-Sender-Class:Date:From:To:Subject; b=WMsk6PAh4AwE8LRFEHRq8zamuJ5Yb1I2fSnMlIXvUbA5F0blo0Qt3vce8eo3pMuEt VLAfYKgsaxK5GW4JJ7o8RLCMsYrw/anaC9GfAdQ3IKReAwKVg1PGCDMSkM+H4g808U TW7sRapDFqsWvfxqjgFmM1/1iUnB4DMIK27X8YMQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.247.214]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MRmfi-1jKeY73Zzm-00TGN1 for ; Thu, 11 Jun 2020 14:16:25 +0200 Date: Thu, 11 Jun 2020 14:17:02 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: grub-mkrescue fails with HFS+ error possibly due to directory size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <40657092990747773@scdbackup.webframe.org> X-Provags-ID: V03:K1:9UlYj4CTtIZoBiPW6GwGCpIs++hBZRJY9EEvOVjkFlZzP4n7oGe zUwshNTkW2jfjWtGiNRp5FU4U8iO7qtMcPrRvhOG8tl8UzwXM6l6cWlLQyGBwbSa5Z/TsDU kPcRP0HmmHP7rWXfuaK0xPLZrT6yNZ/JG5mMZVbdwa1vXscWOAN2Xfnf4x6LqSw99IAKUBU LOTCSsh9EOODsx8fdsgQw== X-UI-Out-Filterresults: notjunk:1;V03:K0:BsfFGPAbKCs=:cZB0CPHNgoKr6IWX6OPIBg loWWGVt69BD0dyoddEimpHwhSsfFUCCkkDF86Lck1D0K4PgHxJdURQWoAvIOhrfjJJku6X+xs vVqTBYEs2wN2s24W1h3TgTcpg4o0amBVASseGa825Bly9B4GmMBcVBLjQEGygfQCl2GFSyxSq BFElXBZybqciPa3Lgot3pRKBteJPo0Zjz1enzBaTUGfiyVitnjReVE4NRQ0L3DKekN1L38f4Q 0UYpPjer+FnaXvxGhcYQOySJS6rgnaF1QXdQWQlugxYXh0QrPN16xKM/j7PPdmhC4wHYjryP3 35++j9/GnKSZoRVum0YvPO2EUHmVL9BWRUsNNfU4MBhz4DxKouP21VclaDtCPM9nZg1IC0FD8 OzYUibiz5VMvkau8227Kt5hHn7SBFd9AGlXX5C4pIkoDtaYqWtkr7ZK1SFGJM7i0RJ/xpjKgI 3iQqM6xnCUChCAM9qgMOef35tcI5MlpMaFAUvF1W/O3/2RqJCt2iD2T3QrhU1mj/DHGULdrCU N39LG4aL/d20LHsdDq65MD+a08goB+mH9sZvlVVyGv0oTQzB5PnmCk+GHI8otdjPwHsV3Uhg1 qBADtkF7YGrYMlnfeJAZus5GWCeNHe7o1tYsma+9+VyALytw6O6xY+K9X189RH9Y6gmweseSw Z3owKW43UZW3N/c/h3szioDXZFHoS45RvK0JPtQx99FacleL8KsaLg0MmcJyTDCD1nUHunHmh 8x3v8FA4QKR2TZ+xFTA95/Y0bk3cNkP9yKS600+K6gTfz2d0H9SMsj3QBtf1WiIgkgX2AoyoB avJB9zct4FA/jnKQNFjF3neiOdyJmfkTUyPVSz+amIwv32PXSKO7NZERTipctJ2w/FDJ6ZPyw zfQiUMLS1pgKO0uuoRuITJpeX4bfhn7T5ee5yEz7EJujNnv3hiRyQH/drunkGptzdhXg6MJW5 rSx8Fn35mxz+II1tSrJjQTBSs3isZlSCXw5afSks7786Gg3aWXv8GSLsW08jjE4y+fgSH2D+u wnDk860NE6YIsvuHTFERiQ7p4PDwqpm+G8xsdFsjfiO2oobb49ydFdigSbwgvPpzr3yqRTs5O sgoQjMRvYOwLdfoeE8XSXzWQKYHzIciVmJyH24CIalCtCqf6b6jLoAB+fD1l58QQV+6TXKBtj IXRVqW6KI2Lmnk9X1jLVoXVXp0ajTOwwbkadGa7pJru/g9rajeifFgSjwRfhwN2S1Xe0Y= Received-SPF: pass client-ip=212.227.17.20; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/11 08:16:26 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 12:16:29 -0000 Hi, i just got a bug report about Guix ISO image production failing with libisofs: FAILURE : HFS+ map nodes aren't implemented The message stems from the HFS+ contribution to libisofs by Vladimir Serbinenko in 2012. About the only program which asks libisofs to produce HFS+ is grub-mkrescue, which to my knowledge is indeed used by Guix. I need a confirmation of my preliminary diagnosis and, if true, a decision how important HFS+ is nowadays for grub-mkrescue. I believe to see a limitation to 30720 files per directory, which would become an official limitation of grub-mkrescue if HFS+ production shall be continued for I386, X86_64, and POWERPC_IEEE1275. =2D----------------------------------------------------------------------- The code which issues the error is in https://dev.lovelyhq.com/libburnia/libisofs/raw/master/libisofs/hfsplus.= c line 1791: if (target->hfsp_nnodes > (cat_node_size - 0x100) * 8) { iso_msg_submit(target->image->id, ISO_MANGLE_TOO_MUCH_FILES, 0, "HFS+ map nodes aren't implemented"); ret =3D ISO_MANGLE_TOO_MUCH_FILES; goto ex; } This looks not like a mangling problem but more like a plain overflow. target->hfsp_nnodes is a counter which i have difficulties to understand: target->hfsp_levels[level].level_size++; target->hfsp_nnodes +=3D target->hfsp_levels[level].level_size; cat_node_size is set by target->hfsp_cat_node_size =3D 2 * target->opts->hfsp_block_size; ... cat_node_size =3D target->hfsp_cat_node_size; target->opts->hfsp_block_size is most probably HFSPLUS_DEFAULT_BLOCK_SIZE =3D 2048. My rough theory is that a HFS+ directory cannot have more than (4096 - 256) * 8 =3D 30720 file names. There seems to be a workaround "HFS+ map nodes". But the HFS+ code in libisofs reports not to have it implemented. Have a nice day :) Thomas