Re: [PATCH] peer_pid checking in ip_queue

[Patrick McHardy <kaber@trash.net>]

Harald Welte wrote:
> On Tue, Mar 23, 2004 at 11:44:15PM +0100, Patrick McHardy wrote:
> 
>>It can happen if peer_pid is checked outside the locked section on one
>>CPU and changed on another at the same time. I don't consider it
>>important, as the exact point in time at which the first packet will be
>>received is non-deterministic for userspace anyway. But we can probably
>>also do it without a race-conditions, ipq_build_packet_message
>>read_locks queue_lock, directly after that it is write_locked by
>>ipq_enqueue_packet. As multiple threads will queue at the write_lock
>>anyway it seems we can just replace it by a spin_lock and lock the
>>entire section. But let me think some more about it ..
> 
> 
> any results so far?  If not, I will just postpone this minor issue.

Not yet, but I will get to it next week.

> 
> 
>>Regards
>>Patrick
> 
> 
>