Re: [PATCH] reset: gpio: Add self-deasserting reset callback

[Krzysztof Kozlowski <krzk@kernel.org>]

On 31/01/2025 15:58, Shenwei Wang wrote:
>>> +#include <linux/delay.h>
>>>  #include <linux/gpio/consumer.h>
>>>  #include <linux/mod_devicetable.h>
>>>  #include <linux/module.h>
>>> @@ -37,6 +38,17 @@ static int reset_gpio_deassert(struct
>> reset_controller_dev *rc,
>>>       return 0;
>>>  }
>>>
>>> +static int reset_gpio_reset(struct reset_controller_dev *rc, unsigned
>>> +long id) {
>>> +     struct reset_gpio_priv *priv = rc_to_reset_gpio(rc);
>>> +
>>> +     gpiod_set_value_cansleep(priv->reset, 1);
>>> +     usleep_range(10, 20);
>>
>>
>> No, because this is some arbitrary value which might or might not work.
>> If this gets accepted, next person will change it to their own need.
>> Then next person will revert previous change... and so on.
>>
> 
> If the arbitrary value is a concern, would moving it to the DTS be an appropriate solution?
> This may give the user more flexible.

Sure, as discussed when this series were upstreamed and as discussed
with Sean's patchset. BTW, Sean's mentioned need to revive his work, but
I think it did not materialize.

Best regards,
Krzysztof