From: Zach Brown <zab@zabbo.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] old patches never die?
Date: Mon, 29 Mar 2004 03:39:53 +0000 [thread overview]
Message-ID: <40679A89.1020000@zabbo.net> (raw)
In-Reply-To: <20040329014927.38963.qmail@web60501.mail.yahoo.com>
> - for_each_pgdat(pgdat)
> - kernel_thread(kswapd, pgdat, CLONE_KERNEL);
> + for_each_pgdat(pgdat) {
> + ret = kernel_thread(kswapd, pgdat, CLONE_KERNEL);
> + if (ret < 0)
> + panic("%s: unable to initialise kswapd\n", __FUNCTION__);
> + }
If we're going to the trouble of storing 'ret' instead of just checking
the return of kernel_thread(), it sure would be nice to include it in
the panic() output.
- z
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-03-29 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 1:49 [Kernel-janitors] old patches never die? Carl Spalletta
2004-03-29 3:39 ` Zach Brown [this message]
2004-03-29 4:33 ` Michael Still
2004-03-30 22:40 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40679A89.1020000@zabbo.net \
--to=zab@zabbo.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.