From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Wed, 25 Apr 2018 10:28:37 +0000 Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Message-Id: <4069198.SojKMEipNL@avalon> List-Id: References: <10529104.rM2F4eJv5O@avalon> <7644bb92-e7b2-db27-061b-e0808c7264cd@ti.com> In-Reply-To: <7644bb92-e7b2-db27-061b-e0808c7264cd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Linux Media Mailing List Hi Tomi, On Wednesday, 25 April 2018 13:10:43 EEST Tomi Valkeinen wrote: > On 25/04/18 13:02, Laurent Pinchart wrote: > > On Wednesday, 25 April 2018 12:33:53 EEST Tomi Valkeinen wrote: > >> On 25/04/18 12:03, Laurent Pinchart wrote: > >>> Could we trim down omapfb to remove support for the devices supported by > >>> omapdrm ? > >> > >> I was thinking about just that. But, of course, it's not quite > >> straightforward either. > >> > >> We've got DSI manual update functionality in OMAP3-OMAP5 SoCs, which > >> covers a lot of devices. > > > > Sebastian is working on getting that feature in omapdrm, isn't he ? > > Yes, and I keep pushing it forward because of the restructuring you're > doing =) (feel free to comment on that thread). But agreed, it's getting > better. When we have manual update support, I think the biggest missing > feature is then in omapdrm. > > >> And VRFB on OMAP2/3. > > > > And that's something I'd really like to have in omapdrm too. > > Considering how much headache TILER has given, I'm not exactly looking > forward to it ;). > > If we get manual update and VRFB, I think we are more or less covered on > the supported HW features. It'll still break userspace apps which use > omapfb, though. Unless we also port the omapfb specific IOCTLs and the > sysfs files, which I believe we should not. I agree with you, we shouldn't. We'll need a grace period before removing omapfb, if we ever do so. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Wed, 25 Apr 2018 13:28:37 +0300 Message-ID: <4069198.SojKMEipNL@avalon> References: <10529104.rM2F4eJv5O@avalon> <7644bb92-e7b2-db27-061b-e0808c7264cd@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 670C46E23B for ; Wed, 25 Apr 2018 10:28:23 +0000 (UTC) In-Reply-To: <7644bb92-e7b2-db27-061b-e0808c7264cd@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Linux Media Mailing List List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKCk9uIFdlZG5lc2RheSwgMjUgQXByaWwgMjAxOCAxMzoxMDo0MyBFRVNUIFRvbWkg VmFsa2VpbmVuIHdyb3RlOgo+IE9uIDI1LzA0LzE4IDEzOjAyLCBMYXVyZW50IFBpbmNoYXJ0IHdy b3RlOgo+ID4gT24gV2VkbmVzZGF5LCAyNSBBcHJpbCAyMDE4IDEyOjMzOjUzIEVFU1QgVG9taSBW YWxrZWluZW4gd3JvdGU6Cj4gPj4gT24gMjUvMDQvMTggMTI6MDMsIExhdXJlbnQgUGluY2hhcnQg d3JvdGU6Cj4gPj4+IENvdWxkIHdlIHRyaW0gZG93biBvbWFwZmIgdG8gcmVtb3ZlIHN1cHBvcnQg Zm9yIHRoZSBkZXZpY2VzIHN1cHBvcnRlZCBieQo+ID4+PiBvbWFwZHJtID8KPiA+PiAKPiA+PiBJ IHdhcyB0aGlua2luZyBhYm91dCBqdXN0IHRoYXQuIEJ1dCwgb2YgY291cnNlLCBpdCdzIG5vdCBx dWl0ZQo+ID4+IHN0cmFpZ2h0Zm9yd2FyZCBlaXRoZXIuCj4gPj4gCj4gPj4gV2UndmUgZ290IERT SSBtYW51YWwgdXBkYXRlIGZ1bmN0aW9uYWxpdHkgaW4gT01BUDMtT01BUDUgU29Dcywgd2hpY2gK PiA+PiBjb3ZlcnMgYSBsb3Qgb2YgZGV2aWNlcy4KPiA+IAo+ID4gU2ViYXN0aWFuIGlzIHdvcmtp bmcgb24gZ2V0dGluZyB0aGF0IGZlYXR1cmUgaW4gb21hcGRybSwgaXNuJ3QgaGUgPwo+IAo+IFll cywgYW5kIEkga2VlcCBwdXNoaW5nIGl0IGZvcndhcmQgYmVjYXVzZSBvZiB0aGUgcmVzdHJ1Y3R1 cmluZyB5b3UncmUKPiBkb2luZyA9KSAoZmVlbCBmcmVlIHRvIGNvbW1lbnQgb24gdGhhdCB0aHJl YWQpLiBCdXQgYWdyZWVkLCBpdCdzIGdldHRpbmcKPiBiZXR0ZXIuIFdoZW4gd2UgaGF2ZSBtYW51 YWwgdXBkYXRlIHN1cHBvcnQsIEkgdGhpbmsgdGhlIGJpZ2dlc3QgbWlzc2luZwo+IGZlYXR1cmUg aXMgdGhlbiBpbiBvbWFwZHJtLgo+IAo+ID4+IEFuZCBWUkZCIG9uIE9NQVAyLzMuCj4gPiAKPiA+ IEFuZCB0aGF0J3Mgc29tZXRoaW5nIEknZCByZWFsbHkgbGlrZSB0byBoYXZlIGluIG9tYXBkcm0g dG9vLgo+IAo+IENvbnNpZGVyaW5nIGhvdyBtdWNoIGhlYWRhY2hlIFRJTEVSIGhhcyBnaXZlbiwg SSdtIG5vdCBleGFjdGx5IGxvb2tpbmcKPiBmb3J3YXJkIHRvIGl0IDspLgo+IAo+IElmIHdlIGdl dCBtYW51YWwgdXBkYXRlIGFuZCBWUkZCLCBJIHRoaW5rIHdlIGFyZSBtb3JlIG9yIGxlc3MgY292 ZXJlZCBvbgo+IHRoZSBzdXBwb3J0ZWQgSFcgZmVhdHVyZXMuIEl0J2xsIHN0aWxsIGJyZWFrIHVz ZXJzcGFjZSBhcHBzIHdoaWNoIHVzZQo+IG9tYXBmYiwgdGhvdWdoLiBVbmxlc3Mgd2UgYWxzbyBw b3J0IHRoZSBvbWFwZmIgc3BlY2lmaWMgSU9DVExzIGFuZCB0aGUKPiBzeXNmcyBmaWxlcywgd2hp Y2ggSSBiZWxpZXZlIHdlIHNob3VsZCBub3QuCgpJIGFncmVlIHdpdGggeW91LCB3ZSBzaG91bGRu J3QuIFdlJ2xsIG5lZWQgYSBncmFjZSBwZXJpb2QgYmVmb3JlIHJlbW92aW5nIApvbWFwZmIsIGlm IHdlIGV2ZXIgZG8gc28uCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:38758 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbeDYK2X (ORCPT ); Wed, 25 Apr 2018 06:28:23 -0400 From: Laurent Pinchart To: Tomi Valkeinen Cc: Mauro Carvalho Chehab , Bartlomiej Zolnierkiewicz , Linux Media Mailing List , Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Wed, 25 Apr 2018 13:28:37 +0300 Message-ID: <4069198.SojKMEipNL@avalon> In-Reply-To: <7644bb92-e7b2-db27-061b-e0808c7264cd@ti.com> References: <10529104.rM2F4eJv5O@avalon> <7644bb92-e7b2-db27-061b-e0808c7264cd@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Tomi, On Wednesday, 25 April 2018 13:10:43 EEST Tomi Valkeinen wrote: > On 25/04/18 13:02, Laurent Pinchart wrote: > > On Wednesday, 25 April 2018 12:33:53 EEST Tomi Valkeinen wrote: > >> On 25/04/18 12:03, Laurent Pinchart wrote: > >>> Could we trim down omapfb to remove support for the devices supported by > >>> omapdrm ? > >> > >> I was thinking about just that. But, of course, it's not quite > >> straightforward either. > >> > >> We've got DSI manual update functionality in OMAP3-OMAP5 SoCs, which > >> covers a lot of devices. > > > > Sebastian is working on getting that feature in omapdrm, isn't he ? > > Yes, and I keep pushing it forward because of the restructuring you're > doing =) (feel free to comment on that thread). But agreed, it's getting > better. When we have manual update support, I think the biggest missing > feature is then in omapdrm. > > >> And VRFB on OMAP2/3. > > > > And that's something I'd really like to have in omapdrm too. > > Considering how much headache TILER has given, I'm not exactly looking > forward to it ;). > > If we get manual update and VRFB, I think we are more or less covered on > the supported HW features. It'll still break userspace apps which use > omapfb, though. Unless we also port the omapfb specific IOCTLs and the > sysfs files, which I believe we should not. I agree with you, we shouldn't. We'll need a grace period before removing omapfb, if we ever do so. -- Regards, Laurent Pinchart