From: Jeff Garzik <jgarzik@pobox.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: akpm@osdl.org, greg@kroah.com, scott.feldman@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add PCI_DMA_{64,32}BIT constants
Date: Tue, 30 Mar 2004 17:35:29 -0500 [thread overview]
Message-ID: <4069F631.4070405@pobox.com> (raw)
In-Reply-To: <20040329223604.63d981d0.rddunlap@osdl.org>
Randy.Dunlap wrote:
> On Tue, 23 Mar 2004 00:23:05 -0500 Jeff Garzik <jgarzik@pobox.com> wrote:
>
> |
> | Been meaning to do this for ages...
> |
> | Another one for the janitors.
>
>
>>>>Nice, I've pulled this to my pci tree and will forward it on to Linus in
>>>>the next round of pci patches after 2.6.5 is out.
>>>
>>>Yeah well... in the intervening time, somebody on IRC commented
>>>
>>>"so what is so PCI-specific about those constants?"
>>>
>>>They probably ought to be DMA_{32,64}BIT_MASK or somesuch.
>>
>>
>>Heh, ok, care to make up another patch for this? :)
>
>
>
> Here's an updated patch, applies to 2.6.5-rc2-bk9.
> I left the DMA_xxBIT_MASK defines in linux/pci.h, although
> they aren't necessarily PCI-specific. Would we prefer to
> have them in linux/dma-mapping.h ?
Put them whereever the DMA direction constants are, I suppose...
Jeff
next prev parent reply other threads:[~2004-03-30 22:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-23 5:23 [PATCH] add PCI_DMA_{64,32}BIT constants Jeff Garzik
2004-03-27 0:29 ` Greg KH
2004-03-27 0:41 ` Jeff Garzik
2004-03-27 0:48 ` Greg KH
2004-03-27 1:21 ` Jeff Garzik
2004-03-30 6:36 ` Randy.Dunlap
2004-03-30 22:35 ` Jeff Garzik [this message]
2004-03-31 1:26 ` Greg KH
2004-03-31 3:58 ` Randy.Dunlap
2004-03-31 22:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4069F631.4070405@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.