All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nivedita Singhvi <niv@us.ibm.com>
To: David Miller <davem@redhat.com>
Cc: netdev <netdev@oss.sgi.com>
Subject: [PATCH 2.4] reference count clean up continued - IPv6
Date: Tue, 30 Mar 2004 23:00:28 -0800	[thread overview]
Message-ID: <406A6C8C.1000603@us.ibm.com> (raw)

Continuing the reference count clean up, this time
in tcp_v6_rcv().  We should not be doing a sock_put()
on a socket in TIMEWAIT state.

Applies to 2.4.25+.

thanks,
Nivedita

diff -urN linux-2.4.25/net/ipv6/tcp_ipv6.c linux-2.4.25mc6/net/ipv6/tcp_ipv6.c
--- linux-2.4.25/net/ipv6/tcp_ipv6.c	2003-11-28 10:26:21.000000000 -0800
+++ linux-2.4.25mc6/net/ipv6/tcp_ipv6.c	2004-03-30 02:07:05.000000000 -0800
@@ -1647,7 +1647,7 @@
  do_time_wait:
  	if (skb->len < (th->doff<<2) || tcp_checksum_complete(skb)) {
  		TCP_INC_STATS_BH(TcpInErrs);
-		sock_put(sk);
+		tcp_tw_put((struct tcp_tw_bucket *) sk);
  		goto discard_it;
  	}

                 reply	other threads:[~2004-03-31  7:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=406A6C8C.1000603@us.ibm.com \
    --to=niv@us.ibm.com \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.