Re: [PATCH] ibmvscsi driver - sixth version

[Jeff Garzik <jgarzik@pobox.com>]

Andrew Vasquez wrote:
> On Wed, 31 Mar 2004, Jeff Garzik wrote:
> 
> 
>>>>12) in ibmvscsi_probe(), you want to use TASK_UNINTERRUPTIBLE here:
>>>>
>>>>+            set_current_state(TASK_INTERRUPTIBLE);
>>>>+            schedule_timeout(5);
>>>>
>>>>13) in the code pasted in #12, you should pass a value calculated 
>>>>using the 'HZ' constant.
>>>
>>>Hmmm...above code copied from the qlogic driver...and it looked reasonable
>>>to me, but I'll tweak it.
>>
>>Well, qlogic is wrong too.  Do you want to submit a patch fixing qlogic 
>>while you're at it?  ;-)
>>
> 
> 
> Fair enough - the driver isn't checking the return value of
> schedule_timeout() in many cases.  How about the attached patch
> against scsi-misc-2.6.

Looks good to me...

but a question:  in the cases you left TASK_INTERRUPTIBLE, do you care 
at all about signals interrupting the wait?  What are the implications 
of signal delivery and a shorter schedule_timeout() on these remaining 
cases?

	Jeff