From: Thomas Monjalon <thomas@monjalon.net>
To: Michal Krawczyk <mk@semihalf.com>
Cc: dev@dpdk.org, stable@dpdk.org, upstream@semihalf.com,
shaibran@amazon.com, hkalra@marvell.com
Subject: Re: [PATCH] bus/pci: assign driver's pointer before mapping
Date: Sun, 27 Feb 2022 20:14:45 +0100 [thread overview]
Message-ID: <4071325.usQuhbGJ8B@thomas> (raw)
In-Reply-To: <20220119145037.28125-1-mk@semihalf.com>
19/01/2022 15:50, Michal Krawczyk:
> Patch changing the way of accessing interrupt handle also changed order
> of the rte_pci_map_device() call and rte_pci_device:driver assignment.
> It was causing issues with Write Combine mapping on the Linux platform
> if it was used with the igb_uio module.
>
> Linux implementation of pci_uio_map_resource_by_index(), which is called
> by rte_pci_map_device(), needs access to the device's driver. Otherwise
> it won't be able to check the driver's flags and won't respect them.
>
> Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
> Cc: hkalra@marvell.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Looks to be a simple change. I hope there is no side effect.
Applied, thanks.
prev parent reply other threads:[~2022-02-27 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 14:50 [PATCH] bus/pci: assign driver's pointer before mapping Michal Krawczyk
2022-02-24 14:17 ` Michał Krawczyk
2022-02-27 19:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4071325.usQuhbGJ8B@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=mk@semihalf.com \
--cc=shaibran@amazon.com \
--cc=stable@dpdk.org \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.