From: Sid Boyce <sboyce@blueyonder.co.uk>
To: linux-kernel@vger.kernel.org
Subject: Re: 2.6.5-mm1
Date: Tue, 06 Apr 2004 03:46:50 +0100 [thread overview]
Message-ID: <40721A1A.6030705@blueyonder.co.uk> (raw)
In-Reply-To: <20040405153423.GK31152@smtp.west.cox.net>
This is the first kernel since 2.6.5-rc2 to have booted without locking
up on the laptop.
Regards
Sid.
Tom Rini wrote:
>On Mon, Apr 05, 2004 at 01:33:07PM +0100, Sid Boyce wrote:
>
>
>
>>CC arch/x86_64/kernel/setup.o
>>arch/x86_64/kernel/setup.c:258: warning: initialization from
>>incompatible pointer type
>>arch/x86_64/kernel/setup.c: In function `setup_arch':
>>arch/x86_64/kernel/setup.c:411: error: `saved_command_line' undeclared
>>(first use in this function)
>>arch/x86_64/kernel/setup.c:411: error: (Each undeclared identifier is
>>reported only once
>>arch/x86_64/kernel/setup.c:411: error: for each function it appears in.)
>>make[1]: *** [arch/x86_64/kernel/setup.o] Error 1
>>make: *** [arch/x86_64/kernel] Error 2
>>-------------------------------------------------------------------
>>strlcpy(saved_command_line, early_command_line, COMMAND_LINE_SIZE);
>>
>>
>
>Yes, something like this is needed, on top of Rusty's early_param patch:
>diff -puN include/linux/init.h~fix-rusty include/linux/init.h
>--- linux-2.6.5-rc3/include/linux/init.h~fix-rusty 2004-04-02 08:30:50.600483739 -0700
>+++ linux-2.6.5-rc3-trini/include/linux/init.h 2004-04-02 08:30:50.604482833 -0700
>@@ -143,6 +143,7 @@ extern void setup_arch(void);
>
> /* Relies on saved_command_line being set */
> void __init parse_early_options(void);
>+extern char saved_command_line[];
> #endif /* __ASSEMBLY__ */
>
> /**
>
>Assuming that is, that arch/x86_64/kernel/setup.c has #include
><linux/init.h>, which I assume it does.
>
>
>
--
Sid Boyce .... Hamradio G3VBV and keen Flyer
Linux Only Shop.
next prev parent reply other threads:[~2004-04-06 2:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-05 12:33 2.6.5-mm1 Sid Boyce
2004-04-05 15:34 ` 2.6.5-mm1 Tom Rini
2004-04-06 2:30 ` 2.6.5-mm1 Sid Boyce
2004-04-06 2:46 ` Sid Boyce [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-04-05 2:45 2.6.5-mm1 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40721A1A.6030705@blueyonder.co.uk \
--to=sboyce@blueyonder.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.