All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Veeck <michael.veeck@gmx.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] clean up  drivers/scsi/pcmcia/nsp_cs
Date: Wed, 07 Apr 2004 07:56:23 +0000	[thread overview]
Message-ID: <4073B427.9080109@gmx.net> (raw)
In-Reply-To: <407340C0.7050401@gmx.net>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]


Daniele Bellucci wrote:
> On Wed, Apr 07, 2004 at 01:44:00AM +0200, Michael Veeck wrote:
> |This patch (against 2.6.5) removes some unnecessary macros from 
> |drivers/scsi/pcmcia/nsp_cs.c and .h
> |
> |One Question: Like MIN/MAX and ARRAY_SIZE, it seems that BIT(x) is also 
> | defined a thousand times in the kernel. But which macro should be 
> |used? Here I included linux/input.h, but I do appreciate feedback on 
> |which version is the safest.
> 
> .. the problem occours with the dbg/info/warn macros defined in include/linux/usb.h
> 
> there are many other places where macro like that are defined in a different way,
> why don't we store all these usefull macros to a different file?
> 

Well, some (like the ones I mentioned) are already in 
include/linux/kernel.h. That could be the right place for a safe BIT 
method I think.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-04-07  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-06 23:44 [Kernel-janitors] [PATCH] clean up drivers/scsi/pcmcia/nsp_cs Michael Veeck
2004-04-07  7:49 ` Daniele Bellucci
2004-04-07  7:56 ` Michael Veeck [this message]
2004-04-07 23:40 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4073B427.9080109@gmx.net \
    --to=michael.veeck@gmx.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.