From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control Date: Sat, 24 Jan 2015 16:14:54 +0100 Message-ID: <4077998.GJIlik9CKQ@phil> References: <1421922597-18351-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gloria.sntech.de (gloria.sntech.de [95.129.55.99]) by gabe.freedesktop.org (Postfix) with ESMTP id 851CB6E0D3 for ; Sat, 24 Jan 2015 07:15:02 -0800 (PST) In-Reply-To: <1421922597-18351-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Mark Yao List-Id: dri-devel@lists.freedesktop.org QW0gRG9ubmVyc3RhZywgMjIuIEphbnVhciAyMDE1LCAxODoyOTo1NSBzY2hyaWViIE1hcmsgWWFv Ogo+IGRybSBkcG1zIGhhdmUgbWFueSBwb3dlciBtb2RlcywgT04sT0ZGLFNVU1BFTkQsU1RBTkRC WSwgZXRjLgo+IGJ1dCB2b3Agb25seSBoYXZlIGVuYWJsZS9kaXNhYmxlIG1vZGUsIG1heWJlIGNh c2Ugc3VjaCBidWc6Cj4gIC0tPiBEUk1fRFBNU19PTjogcG93ZXIgb24gdm9wCj4gIC0tPiBEUk1f RFBNU19TVVNQRU5EOiBwb3dlciBvZmYgdm9wCj4gIC0tPiBEUk1fRFBNU19PRkY6IGFscmVhZHkg cG93ZXIgb2ZmIGF0IFNVU1BFTkQsIGNyYXNoCj4gc28gdXNlIGEgYm9vbCB2YWwgaXMgbW9yZSBz dWl0YWJsZS4KPiAKPiBhbm90aGVyIHByb2JsZW0gYXQgdm9wX2NydGNfZHBtczoKPiAgIHZvcF9l bmFibGUoKS0+ZHJtX3ZibGFua19vbiwgZHJtX3ZibGFua19vbiBtYXkgY2FsbCB2b3AKPiBlbmFi bGUgdmJsYW5rLiBpZiBpdCBoYXBwZW4sIHZibGFuayBlbmFibGUgd291bGQgZmFpbGVkLAo+IHRo ZW4gY2F1c2UgaXJxIHN0YXR1cyBlcnJvci4gYmVjYXVzZSBpc19lbmFibGVkIHZhbHVlIGlzIHNl dAo+IGFmdGVyIGRybV92Ymxhbmtfb24uCgpUaGlzIHNlcmllcywgb24gYSByazMyODgtZmlyZWZs eSBib2FyZCB3aXRoIGEgc2RhNzEyMyB2Z2EgY29ubmVjdG9yClRlc3RlZC1ieTogSGVpa28gU3R1 ZWJuZXIgPGhlaWtvQHNudGVjaC5kZT4KCgpIZWlrbwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753999AbbAXPPI (ORCPT ); Sat, 24 Jan 2015 10:15:08 -0500 Received: from gloria.sntech.de ([95.129.55.99]:35871 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753540AbbAXPPE (ORCPT ); Sat, 24 Jan 2015 10:15:04 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: dri-devel@lists.freedesktop.org Cc: Mark Yao , David Airlie , Daniel Vetter , Rob Clark , Philipp Zabel , Daniel Kurtz , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control Date: Sat, 24 Jan 2015 16:14:54 +0100 Message-ID: <4077998.GJIlik9CKQ@phil> User-Agent: KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1421922597-18351-1-git-send-email-mark.yao@rock-chips.com> References: <1421922597-18351-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 22. Januar 2015, 18:29:55 schrieb Mark Yao: > drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc. > but vop only have enable/disable mode, maybe case such bug: > --> DRM_DPMS_ON: power on vop > --> DRM_DPMS_SUSPEND: power off vop > --> DRM_DPMS_OFF: already power off at SUSPEND, crash > so use a bool val is more suitable. > > another problem at vop_crtc_dpms: > vop_enable()->drm_vblank_on, drm_vblank_on may call vop > enable vblank. if it happen, vblank enable would failed, > then cause irq status error. because is_enabled value is set > after drm_vblank_on. This series, on a rk3288-firefly board with a sda7123 vga connector Tested-by: Heiko Stuebner Heiko