Re: [Qemu-devel] [PATCH V8 02/14] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

[Paul Moore <pmoore@redhat.com>]

On Wednesday, August 31, 2011 10:35:53 AM Stefan Berger wrote:
> Index: qemu-git/hw/tpm_tis.c
> ===================================================================
> --- /dev/null
> +++ qemu-git/hw/tpm_tis.c
> @@ -0,0 +1,841 @@
> +/*
> + * tpm_tis.c - QEMU emulator for a 1.2 TPM with TIS interface
> + *
> + * Copyright (C) 2006,2010 IBM Corporation
> + *
> + * Author: Stefan Berger <stefanb@us.ibm.com>
> + *         David Safford <safford@us.ibm.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation, version 2 of the
> + * License.
> + *
> + *
> + * Implementation of the TIS interface according to specs at
> + *
> https://www.trustedcomputinggroup.org/groups/pc_client/TCG_PCClientTPMSpeci
> fication_1-20_1-00_FINAL.pdf 
> + *
> + */

The above link isn't working for me, has it moved or is my timing just really 
bad?  I believe I've found the spec, as well as an updated 1.21 version, on 
the TCG website but the URL is different.  Does it make more sense just to 
point people at the TCG website and provide them the name/version of the 
specification?  If all else fails, keeping a copy in the docs/specs directory 
may not be a terrible idea ...

I know it is a nit, and I'm not trying to be difficult, I'm just trying to get 
up to speed on the TPM details and noticed the link was bad.

> +/*
> + * Write a value to a register of the TIS interface
> + * See specs pages 33-63 for description of the registers
> + */

Since I've already started this email, one more thing ... I've come to realize 
there are quite a few specification documents on the TCG website; I think it 
might be helpful to reference the specification/version along with the page 
number(s) just to remove any ambiguity. 

> +static void tis_mem_writel_intern(void *opaque, target_phys_addr_t addr,
> +                                  uint32_t val, bool hw_access)

-- 
paul moore
virtualization @ redhat