From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: helin.zhang@intel.com
Cc: dev@dpdk.org
Subject: Re: [PATCH] i40e: Fix the issue when resetting the stats for i40e, the stats information will be lost before next time getting the stats
Date: Mon, 03 Aug 2015 18:48:14 +0200 [thread overview]
Message-ID: <4079988.2ivxFWYuMK@xps13> (raw)
In-Reply-To: <1436422141-29024-1-git-send-email-zhe.tao@intel.com>
Helin, your review is needed.
Please check how to write a simple title.
2015-07-09 14:09, Zhe Tao:
> Issue: When calling the reset API to reset all the stats for i40e,
> all the stats will be untracked before the next time calling get stats API.
> Once calling the get stats API it will show all the stats equal zero.
>
> Changes: Calling the get stats API in the reset API will force the stats_offset update immediately
>
> Signed-off-by: Zhe Tao <zhe.tao@intel.com>
[...]
> +
> + /*
> + * need to read the status one time right after reset the offset_loaded field
> + * prevent the stats data loss between the i40e_dev_stats_reset and i40e_dev_stats_get
> + */
This comment seems complicated to understand.
> +
> + i40e_dev_stats_get(dev, &stat);
next prev parent reply other threads:[~2015-08-03 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 6:09 [PATCH] i40e: Fix the issue when resetting the stats for i40e, the stats information will be lost before next time getting the stats Zhe Tao
2015-08-03 16:48 ` Thomas Monjalon [this message]
2015-08-03 17:35 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4079988.2ivxFWYuMK@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.