All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Still <mikal@stillhq.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATHC] fix ide.c warning
Date: Wed, 14 Apr 2004 22:58:12 +0000	[thread overview]
Message-ID: <407DC204.20200@stillhq.com> (raw)
In-Reply-To: <200404140217.i3E2Hrgn023951@p-chan.krl.com>

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Luiz Fernando N. Capitulino wrote:

> | I would think it's much better form to either:
> | 
> |   - put the prototype in a header
> |   - repeat the prototype at the top of this file (there are risks here)
> 
>  I don't think is a good way to create a new .h file only to put
> one prototype there. include/linux/ide.h already does that for another ide
> functions, so it can be used (well, was what a quick look show me).

Hey, I don't really mind which header it goes in. If there is an 
existing suitable header, then that sounds like a good path.

Cheers,
Mikal

-- 

Michael Still (mikal@stillhq.com) | "All my life I've had one dream,
http://www.stillhq.com            |  to achieve my many goals"
UTC + 11                          |    -- Homer Simpson

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2004-04-14 22:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-14  2:17 [Kernel-janitors] [PATHC] fix ide.c warning Don Koch
2004-04-14 18:02 ` Luiz Fernando N. Capitulino
2004-04-14 21:10 ` Michael Still
2004-04-14 21:17 ` Don Koch
2004-04-14 21:33 ` Luiz Fernando N. Capitulino
2004-04-14 21:39 ` Luiz Fernando N. Capitulino
2004-04-14 22:58 ` Michael Still [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=407DC204.20200@stillhq.com \
    --to=mikal@stillhq.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.