Re: [PATCH 1/2] net/ice: check for missing fixed speed setting

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 9/10/2026 5:08 PM, Bruce Richardson wrote:
> When the user requests a fixed speed for a NIC link, the speeds bitmask
> passed must have a speed value actually set in it, as well as the
> "FIXED" flag. Catch this case and log an error message.
> 
> Fixes: 36afbc269081 ("net/ice: support link speed change")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   drivers/net/intel/ice/ice_ethdev.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
> index 76b8ff0a72..dc955d130b 100644
> --- a/drivers/net/intel/ice/ice_ethdev.c
> +++ b/drivers/net/intel/ice/ice_ethdev.c
> @@ -4936,6 +4936,10 @@ ice_apply_link_speed(struct rte_eth_dev *dev)
>   					RTE_ETH_LINK_SPEED_100M;
>   	}
>   	speed = ice_parse_link_speeds(conf->link_speeds);
> +	if (speed == ICE_AQ_LINK_SPEED_UNKNOWN) {
> +		PMD_DRV_LOG(ERR, "No valid link speed setting specified");
> +		return -EINVAL;
> +	}
>   
>   	return ice_phy_conf_link(hw, speed, true);
>   }

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly