From: David Howells <dhowells@redhat.com>
To: Lans Zhang <jia.zhang@windriver.com>
Cc: dhowells@redhat.com, kexec@lists.infradead.org,
vgoyal@redhat.com, bhe@redhat.com
Subject: Re: [PATCH 1/2] PKCS#7: Fix kernel panic when referring to the empty AuthorityKeyIdentifier
Date: Wed, 13 Jul 2016 14:03:31 +0100 [thread overview]
Message-ID: <4080.1468415011@warthog.procyon.org.uk> (raw)
In-Reply-To: <1468399874-5880-1-git-send-email-jia.zhang@windriver.com>
Lans Zhang <jia.zhang@windriver.com> wrote:
> - } else {
> - auth = sig->auth_ids[1];
> + } else if ((auth = sig->auth_ids[1])) {
Better to say:
} else if (auth) {
auth = sig->auth_ids[1];
David
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2016-07-13 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 8:51 [PATCH 1/2] PKCS#7: Fix kernel panic when referring to the empty AuthorityKeyIdentifier Lans Zhang
2016-07-13 8:51 ` [PATCH 2/2] pefile: Fix the failure of calculation for digest Lans Zhang
2016-07-13 13:06 ` David Howells
2016-07-13 13:38 ` Lans Zhang
2016-07-13 13:03 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4080.1468415011@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bhe@redhat.com \
--cc=jia.zhang@windriver.com \
--cc=kexec@lists.infradead.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.