From: Thomas Monjalon <thomas@monjalon.net>
To: Sun Yuechi <sunyuechi@iscas.ac.cn>
Cc: dev@dpdk.org, Stanislaw Kardach <stanislaw.kardach@gmail.com>,
uk7b@foxmail.com
Subject: Re: [PATCH v2 2/5] eal/riscv/spinlock: add rte_cpuflag.h
Date: Fri, 19 Sep 2025 17:13:19 +0200 [thread overview]
Message-ID: <40834601.10thIPus4b@thomas> (raw)
In-Reply-To: <tencent_EFCE09AB3F6C9C0743F5C9226108A2D86D05@qq.com>
01/07/2025 20:20, uk7b@foxmail.com:
> From: Sun Yuechi <sunyuechi@iscas.ac.cn>
>
> Same as the x86 style, include "rte_cpuflags.h" in rte_spinlock.h
> so that files like lib/fib/dir24_8.c don’t need to include it.
>
> Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
I disagree.
I prefer removing useless includes like in x86 spinlock.
next prev parent reply other threads:[~2025-09-19 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250701182033.642384-1-uk7b@foxmail.com>
2025-07-01 18:20 ` [PATCH v2 1/5] config/riscv: detect V extension uk7b
2025-08-12 9:21 ` Stanisław Kardach
2025-09-05 2:50 ` 孙越池
2025-07-01 18:20 ` [PATCH v2 2/5] eal/riscv/spinlock: add rte_cpuflag.h uk7b
2025-08-12 9:20 ` Stanisław Kardach
2025-09-19 15:13 ` Thomas Monjalon [this message]
2025-09-19 16:37 ` 孙越池
2025-07-01 18:20 ` [PATCH v2 3/5] lib/lpm: R-V V rte_lpm_lookupx4 uk7b
2025-08-12 9:21 ` Stanisław Kardach
2025-07-01 18:20 ` [PATCH v2 4/5] lib/fib: R-V V rte_fib_lookup_bulk uk7b
2025-08-12 9:22 ` Stanisław Kardach
2025-07-01 18:20 ` [PATCH v2 5/5] riscv: override machine_args only when default uk7b
2025-08-12 9:22 ` Stanisław Kardach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40834601.10thIPus4b@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stanislaw.kardach@gmail.com \
--cc=sunyuechi@iscas.ac.cn \
--cc=uk7b@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.