All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Jones <davej@redhat.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: rcpci45 dereference fix.
Date: Mon, 19 Apr 2004 12:40:38 -0400	[thread overview]
Message-ID: <40840106.80403@pobox.com> (raw)
In-Reply-To: <20040416215037.GV20937@redhat.com>

Dave Jones wrote:
> On Fri, Apr 16, 2004 at 10:45:06PM +0200, Francois Romieu wrote:
> 
>  > rcpci45_init_one() must succeed in order for rcpci45_remove_one() to be
>  > issued.
>  > 
>  > If rcpci45_init_one() succeeds, dev can not be NULL.
>  > 
>  > So I'd rather see the "if (!dev) {" test removed instead of this change.
> 
> Sure.
> 
> 		Dave
> 
> --- drivers/net/rcpci45.c~	2004-04-16 22:22:22.000000000 +0100
> +++ drivers/net/rcpci45.c	2004-04-16 22:49:54.000000000 +0100
> @@ -131,12 +131,6 @@
>  	struct net_device *dev = pci_get_drvdata (pdev);
>  	PDPA pDpa = dev->priv;
>  
> -	if (!dev) {
> -		printk (KERN_ERR "%s: remove non-existent device\n",
> -				dev->name);
> -		return;
> -	}
> -


Manually applied, since it's not in standard "patch -sp1" format.

	Jeff




      reply	other threads:[~2004-04-19 16:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-16 21:23 rcpci45 dereference fix Dave Jones
2004-04-16 20:45 ` Francois Romieu
2004-04-16 21:50   ` Dave Jones
2004-04-19 16:40     ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40840106.80403@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.