From: Jeff Mahoney <jeffm@suse.com>
To: ReiserFS Mailing List <reiserfs-list@namesys.com>
Subject: [PATCH] Another reiserfs_resize fix (unlock_super called incorrectly)
Date: Mon, 19 Apr 2004 14:48:38 -0400 [thread overview]
Message-ID: <40841F06.6020606@suse.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Here's another fix for reiserfs_resize().
If reiserfs_allocate_list_bitmaps() fails, it calls unlock_super on the
sb. This is incorrect, as it didn't lock it initially. do_remount_sb
calls lock_super and unlock_super surrounding the ->remount_fs call,
regardless of error.
The attach patch removes the unlock_super call.
- -Jeff
- --
Jeff Mahoney
SuSE Labs
jeffm@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFAhB8GLPWxlyuTD7IRAq/hAJ9AKMIo26EnvGyjHmaEBh1TaPsnsACfVYvf
PY4TWrNLusOt6WWPjCWjPrs=
=Uc5g
-----END PGP SIGNATURE-----
[-- Attachment #2: reiserfs-resize-2.diff --]
[-- Type: text/plain, Size: 584 bytes --]
diff -rup linux-2.6.5.kgdb/fs/reiserfs/resize.c linux-2.6.5.kgdb.afs/fs/reiserfs/resize.c
--- linux-2.6.5.kgdb/fs/reiserfs/resize.c 2004-04-19 10:28:53.692014416 -0400
+++ linux-2.6.5.kgdb.afs/fs/reiserfs/resize.c 2004-04-19 14:43:05.148440616 -0400
@@ -82,7 +82,6 @@
/* reallocate journal bitmaps */
if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
printk("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
- unlock_super(s) ;
return -ENOMEM ;
}
/* the new journal bitmaps are zero filled, now we copy in the bitmap
reply other threads:[~2004-04-19 18:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40841F06.6020606@suse.com \
--to=jeffm@suse.com \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.