From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wilfried Weissmann Date: Sat, 01 May 2004 16:31:04 +0000 Subject: Re: [RFC] [DRAFT] [udev PATCH] First attempt at vendor RAID support Message-Id: <4093D0C8.5010905@gmx.at> List-Id: References: <40803C61.503@gmx.net> In-Reply-To: <40803C61.503@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset="macroman" Content-Transfer-Encoding: base64 To: Carl-Daniel Hailfinger Cc: Thomas Horsten , Linux Kernel Mailing List , medley@lists.infowares.com, linux-hotplug-devel@lists.sourceforge.net, Jeff Garzik , Bartlomiej Zolnierkiewicz , Greg KH SGksCgpJIGp1c3QgcmV0dXJuZWQgZnJvbSBteSB2YWNhdGlvbiBhbmQgY2hlY2tlZCBteSBlbWFp bHMuIFRoYXQncyB3aHkgdGhlIApyZXNwb25zZSBpcyBzbyBsYXRlLgoKQ2FybC1EYW5pZWwgSGFp bGZpbmdlciB3cm90ZToKPj4+LSBQZW9wbGUgY2hlY2tpbmcgdGhlIG51bWVyb3VzIEZJWE1Fcwo+ IAo+IAo+IEkgbm93IGhhdmUgdGhlIGZvbGxvd2luZyBGSVhNRXMgKGFrYSAiSSBoYXZlIG5vIGlk ZWEgYWJvdXQgaXQiKToKPiAtIDUgRklYTUVzIGluIHRoZSBNZWRsZXkgUkFJRCBjb2RlLiBUaG9t YXMsIGNvdWxkIHlvdSBjb21tZW50IG9uY2UgeW91J3JlCj4gYmFjaz8KPiAtIDMgRklYTUVzIGlu IHRoZSBIaWdocG9pbnQgUkFJRCBjb2RlLiBXaWxmcmllZCwgY291bGQgeW91IHBsZWFzZSB0YWtl IGEKPiBsb29rIGF0IHRoZW0/CgoxKSBGSVhNRTogRG9lcyAibm8gYXJyYXkgZGVmaW5lZCIgY29y cmVzcG9uZCB0byBIUFRfVF9TSU5HTEVESVNLPwpJIGhhdmUgdG8gY2hlY2sgdGhpcyBidXQgSSBi ZWxpZXZlIGl0IGlzIHNvLgoKMikgRklYTUU6IElzIEhQVF9UX1JBSURfMDFfUkFJRF8xIGEgdmFs dWUgdGhhdCBjYW4gZXZlciBiZSBmb3VuZD8KSSB0aGluayB0aGlzIGlzIHRoZSBuZXcgc3R5bGUg cmFpZC0xMCBmb3JtYXQgdGhhdCBpcyBzdXBwb3J0ZWQgYnkgaHB0Mzc0IAphbmQgdXB3YXJkcy4g SSBkbyBub3QgaGF2ZSBzdWNoIGEgY29udHJvbGxlciBzbyBJIGNhbm5vdCB2ZXJpZnkgdGhpcy4K CjMpIEZJWE1FOiB3aGF0IGRvZXMgSFBUX01BR0lDX0JBRCBtZWFuPwpZb3UgZ2V0IHRoaXMgaWYg eW91IHB1bGwgb25lIGRpc2sgb3V0IG9mIGEgcmFpZC0wIGFycmF5IGZvciBleGFtcGxlLiBUaGUg CkhQVC1CSU9TIGRldGVjdHMgdGhhdCB0aGUgcmFpZCBpcyBub3Qgb3BlcmF0aW9uYWwgYW5kIG1h cmtzIHRoZSBhcnJheSBhcyAKYmFkICh3cml0ZXMgdGhlIEhQVF9NQUdJQ19CQUQgdG8gdGhlIHJl bWFpbmluZyBkaXNrcykuCgpbc25pcF0KCj4+Pi0gTW9yZSBkYXRhIGFib3V0IE1lZGxleS9IaWdo cG9pbnQgdmVuZG9yIHN1cGVyYmxvY2tzIChjYW4gSSBjaGVjayBmb3IKPj4+Ym9ndXMgdmFsdWVz PykKPiAKPiAKPiBXaWxmcmllZCwgaXMgdGhlcmUgYW55IGNvbnNpc3RlbmN5IGNoZWNrIEkgY2Fu IGFkZCBmb3IgSGlnaHBvaW50PwoKSSBoYXZlIG5vdCBmb3VuZCBhbnkgY3JjIG9yIHNvLiBCdXQg c2luY2UgSFBUIG1hcmtzIGFueSBkaXNrcyB0aGF0IGlzIApub3QgaW4gYW4gYXJyYXkgYXMgSFBU X1RfU0lOR0xFRElTSyBvciBIUFRfTUFHSUNfQkFEIHdlIHNob3VsZCBiZSBmaW5lIAp1bmxlc3Mg c29tZW9uZSB3cml0ZXMgc29tZSBnYXJiYWdlIHRvIHRoZSBzdXBlcmJsb2NrLgoKPiAKPiAKPiAK Pj4+LSBIZWxwIHdpdGggc29ydGluZyBvdXQgd2hvIG93bnMgd2hpY2ggY29weXJpZ2h0cwo+IAo+ IAo+IFRoaXMgaXMgc3RpbGwgYSBfYmlnIGlzc3VlXy4KClRoZSBIUFQgY29weXJpZ2h0cyBsb29r IGZpbmUuCgpJIGFtIGxvb2tpbmcgZm9yd2FyZCB0byBzZWUgdGhlIHBhcnQgdGhhdCB3cml0ZXMg dGhlIGRtIGNvbmZpZ3VyYXRpb24gc28gCnRoYXQgSSBjYW4gaW50ZWdyYXRlIGl0IGludG8gdGhl IGV2bXMgcGx1Z2luLgoKYnllLAp3aWxmcmllZAoKUFM6IGFkZF9kaXNrX3RvX3JhaWRsaXN0cygp IGRvZXMgbmV2ZXIgcmV0dXJuIHJldHZhbCEKCgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tClRoaXMgU0YuTmV0IGVtYWlsIGlzIHNwb25zb3Jl ZCBieTogT3JhY2xlIDEwZwpHZXQgY2VydGlmaWVkIG9uIHRoZSBob3R0ZXN0IHRoaW5nIGV2ZXIg dG8gaGl0IHRoZSBtYXJrZXQuLi4gT3JhY2xlIDEwZy4gClRha2UgYW4gT3JhY2xlIDEwZyBjbGFz cyBub3csIGFuZCB3ZSdsbCBnaXZlIHlvdSB0aGUgZXhhbSBGUkVFLiAKaHR0cDovL2Fkcy5vc2Ru LmNvbS8/YWRfaWQxNDkmYWxsb2NfaWSBNjYmb3A9Y2xpY2sKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtaG90cGx1Zy1kZXZlbCBtYWlsaW5nIGxp c3QgIGh0dHA6Ly9saW51eC1ob3RwbHVnLnNvdXJjZWZvcmdlLm5ldApMaW51eC1ob3RwbHVnLWRl dmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9s aXN0cy9saXN0aW5mby9saW51eC1ob3RwbHVnLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261156AbUEAQbR (ORCPT ); Sat, 1 May 2004 12:31:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261380AbUEAQbR (ORCPT ); Sat, 1 May 2004 12:31:17 -0400 Received: from pop.gmx.de ([213.165.64.20]:55760 "HELO mail.gmx.net") by vger.kernel.org with SMTP id S261156AbUEAQbO (ORCPT ); Sat, 1 May 2004 12:31:14 -0400 X-Authenticated: #7370606 Message-ID: <4093D0C8.5010905@gmx.at> Date: Sat, 01 May 2004 18:31:04 +0200 From: Wilfried Weissmann User-Agent: Mozilla Thunderbird 0.5 (X11/20040306) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Carl-Daniel Hailfinger CC: Thomas Horsten , Linux Kernel Mailing List , medley@lists.infowares.com, linux-hotplug-devel@lists.sourceforge.net, Jeff Garzik , Bartlomiej Zolnierkiewicz , Greg KH Subject: Re: [RFC] [DRAFT] [udev PATCH] First attempt at vendor RAID support in 2.6 References: <40803C61.503@gmx.net> In-Reply-To: <40803C61.503@gmx.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, I just returned from my vacation and checked my emails. That's why the response is so late. Carl-Daniel Hailfinger wrote: >>>- People checking the numerous FIXMEs > > > I now have the following FIXMEs (aka "I have no idea about it"): > - 5 FIXMEs in the Medley RAID code. Thomas, could you comment once you're > back? > - 3 FIXMEs in the Highpoint RAID code. Wilfried, could you please take a > look at them? 1) FIXME: Does "no array defined" correspond to HPT_T_SINGLEDISK? I have to check this but I believe it is so. 2) FIXME: Is HPT_T_RAID_01_RAID_1 a value that can ever be found? I think this is the new style raid-10 format that is supported by hpt374 and upwards. I do not have such a controller so I cannot verify this. 3) FIXME: what does HPT_MAGIC_BAD mean? You get this if you pull one disk out of a raid-0 array for example. The HPT-BIOS detects that the raid is not operational and marks the array as bad (writes the HPT_MAGIC_BAD to the remaining disks). [snip] >>>- More data about Medley/Highpoint vendor superblocks (can I check for >>>bogus values?) > > > Wilfried, is there any consistency check I can add for Highpoint? I have not found any crc or so. But since HPT marks any disks that is not in an array as HPT_T_SINGLEDISK or HPT_MAGIC_BAD we should be fine unless someone writes some garbage to the superblock. > > > >>>- Help with sorting out who owns which copyrights > > > This is still a _big issue_. The HPT copyrights look fine. I am looking forward to see the part that writes the dm configuration so that I can integrate it into the evms plugin. bye, wilfried PS: add_disk_to_raidlists() does never return retval!