From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Pablo Neira <pablo@eurodev.net>,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>
Subject: Re: locking issue in ip_conntrack_alter_reply
Date: Mon, 03 May 2004 14:15:23 +0200 [thread overview]
Message-ID: <409637DB.6030600@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.33.0405031057120.24224-100000@blackhole.kfki.hu>
Jozsef Kadlecsik wrote:
>On Fri, 30 Apr 2004, Pablo Neira wrote:
>
>
>
>>I'll study if that assertion is right before submitting a patch.
>>
>>
>
>The assertion is right, because we alter unconfirmed packets when setting
>up nat info. And you're also right, write-locking is unnecessary: the
>entry is not in the hash table yet, so nobody else can grab and modify the
>conntrack entry. [And it is overlooked in the per bucket locking patch too.]
>
>
I've ported your conntrack patches to 2.6, I will include this change
before adding them to CVS.
Regards
Patrick
>Best regards,
>Jozsef
>-
>E-mail : kadlec@blackhole.kfki.hu, kadlec@sunserv.kfki.hu
>PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
>Address : KFKI Research Institute for Particle and Nuclear Physics
> H-1525 Budapest 114, POB. 49, Hungary
>
>
>
next prev parent reply other threads:[~2004-05-03 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-30 17:09 locking issue in ip_conntrack_alter_reply Pablo Neira
2004-05-03 9:05 ` Jozsef Kadlecsik
2004-05-03 12:15 ` Patrick McHardy [this message]
2004-05-03 13:05 ` Pablo Neira
2004-05-03 13:25 ` Henrik Nordstrom
2004-05-03 13:26 ` Pablo Neira
2004-05-03 13:09 ` Jozsef Kadlecsik
2004-05-04 7:01 ` KOVACS Krisztian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409637DB.6030600@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.