Re: [Qemu-devel] QEMU RFB (vnc) driver

[Fabrice Bellard <fabrice@bellard.org>]

Some comments about your patch:

- The configure option '--enable-vnc-and-sdl' must be suppressed. QEMU 
can handle several display interfaces (it has already two). So it is 
better to add a command line option '-vnc' to QEMU to select the VNC 
server display. Another command line option can be added to have both 
sdl and vnc display. Having configure time options _must_ be avoided as 
most users won't recompile QEMU.

- An option '-k keyb_type' must be added to select the type of keyboard.

Fabrice.

Johannes Schindelin wrote:
> Hi,
> 
> First of all: QEMU is wonderful. It is blazingly fast, yet very small!
> 
> Second, my sincere apologies to Matthew: I hacked together my own version
> of what you did. Attached is a patch which does about the same thing.
> 
> A few differences, though:
> 
> 	- I stole a bit from wine, so I have a compile time choice of a
> 	  keymap. This certainly has room to improve.
> 
> 	- I actually change the screen resolution. There is support for
> 	  this in LibVNCServer since version 0.4, and a few clients
> 	  support it. If the client does not support the change, a warning
> 	  is issued.
> 
> 	- It is configurable:
> 		./configure --enable-vnc
> 	  will change the output completely to vnc, and
> 		./configure --enable-vnc-and-sdl
> 	  will use both simultaneously!
> 
> 	- It still contains debug messages for every key you hit (it also
> 	  has those messages in SDL so I can work out why VNC behaves
> 	  differently).