All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@keyaccess.nl>
To: Gerardo Exequiel Pozzi <vmlinuz386@yahoo.com.ar>
Cc: linux-kernel@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl,
	mikeserv@bmts.com
Subject: Re: linux-2.6.6: ide-disks are shutdown on reboot
Date: Tue, 11 May 2004 22:12:47 +0200	[thread overview]
Message-ID: <40A133BF.90403@keyaccess.nl> (raw)
In-Reply-To: <20040511142017.1bc39ce1.vmlinuz386@yahoo.com.ar>

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

Gerardo Exequiel Pozzi wrote:

> With the recent version 2.6.6 my ide disks are shutdown on reboot, 
> this not happens with 2.6.5. I try booting with acpi=off and it
> behaves equal, disk shutdown on reboot.

Wildly annoying isn't it? Seems to be a generic problem with linux not 
differentiatinng between REBOOT and HALT/POWEROFF. Andrew Morton just 
posted a patch to deplex them:

http://marc.theaimsgroup.com/?l=linux-kernel&m=108425291909843&w=2

You can wait for the IDE crowd to use that to implement a proper fix or 
staple the attached hack on top if it must go now.

Rene.



[-- Attachment #2: linux-2.6.6_spin.diff --]
[-- Type: text/plain, Size: 595 bytes --]

--- linux-2.6.6.orig/drivers/ide/ide-disk.c	2004-05-11 12:40:53.000000000 +0200
+++ linux-2.6.6/drivers/ide/ide-disk.c	2004-05-11 12:09:30.000000000 +0200
@@ -1704,10 +1704,11 @@
 
 static void ide_device_shutdown(struct device *dev)
 {
-	ide_drive_t *drive = container_of(dev, ide_drive_t, gendev);
-
-	printk("Shutdown: %s\n", drive->name);
-	dev->bus->suspend(dev, PM_SUSPEND_STANDBY);
+	if (system_state != SYSTEM_RESTART) {
+		ide_drive_t *drive = container_of(dev, ide_drive_t, gendev);
+		printk("Shutdown: %s\n", drive->name);
+		dev->bus->suspend(dev, PM_SUSPEND_STANDBY);
+	}
 }
 
 /*

  reply	other threads:[~2004-05-11 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-11 17:20 linux-2.6.6: ide-disks are shutdown on reboot Gerardo Exequiel Pozzi
2004-05-11 20:12 ` Rene Herman [this message]
2004-05-11 20:36   ` Dmitry Ivanov
2004-05-11 20:57     ` Rene Herman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A133BF.90403@keyaccess.nl \
    --to=rene.herman@keyaccess.nl \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikeserv@bmts.com \
    --cc=vmlinuz386@yahoo.com.ar \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.