Re: SATA ATAPI work in progress

[Jeff Garzik <jgarzik@pobox.com>]

Pat LaVarre wrote:
>>Are you willing to work 
> 
> 
> Yes I want to learn.
> 
> I figure I can learn fastest by helping.
> 
> 
>>on a separate, pre-requisite patch:
>>
>>We need to split ata_bmdma_start_{pio,mmio} into separate "setup" and 
>>"start" pieces.
>>
>>This would involve adding a "bmdma_setup" hook to struct 
>>ata_port_operations in include/linux/libata.h, and then doing a simple
>>update of all the SATA drivers, to use the default libata-core 
>>implementations.
> 
> 
> Sorry as yet I understand very little of the above.
> 
> Until corrected I will guess I should next:


> 4) Report back here for next assignment.

hehe

The above is something that applies to all of libata, and changes the 
libata API so that ATAPI is doable.

It looks something like:

1) add ->bmdma_setup hook to include/linux/libata.h
2) walk through each of drivers/scsi/*ata_*.c and make an adjustment 
like the following:

		.bmdma_start:	ata_bmdma_start_mmio,
	+	.bmdma_setup:	ata_bmdma_setup_mmio,

3) create new functions ata_bmdma_setup_{mmio,pio}.

4) move EVERYTHING except the final writeb() from ata_bmdma_start_mmio 
to ata_bmdma_setup_mmio.

5) do the same for ata_bmdma_{start,setup}_pio.

at this point, it is highly likely that sata_promise.c and sata_sx4.c 
are broken, but the other drivers should work 100%.

for bonus points,

6) fix sata_promise and sata_sx4

otherwise I can do that.



The only hardware required for this task is a SATA hard drive and SATA 
host controller.

	Jeff