From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: 2.6.6-mm2
Date: Fri, 14 May 2004 09:51:40 +1000 [thread overview]
Message-ID: <40A40A0C.3070906@yahoo.com.au> (raw)
In-Reply-To: <40A36C94.EB004C37@tv-sign.ru>
Oleg Nesterov wrote:
> Hello.
>
> Andrew Morton wrote:
>
>>+yield_irq.patch
>>
>>From: Nick Piggin
>>
>>this_rq_lock does a local_irq_disable, and sched_yield()
>>needs to undo that.
>
>
> I beleive it is safe to enter schedule() with interrupts
> disabled. schedule() does spin_lock_irq()->local_irq_disable()
> anyway.
>
> Could you please explain, why it is needed?
>
It is safe to enter schedule() with interrupts disabled. I
found this "problem" while searching for something else in
sched.c
For consistency it is a good thing to do, however I would
be just as happy with a 1 line comment instead. Ingo what
do you prefer?
next prev parent reply other threads:[~2004-05-14 0:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-13 12:39 2.6.6-mm2 Oleg Nesterov
2004-05-13 18:28 ` 2.6.6-mm2 Andrew Morton
2004-05-13 23:51 ` Nick Piggin [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-05-14 18:51 2.6.6-mm2 Jan Killius
[not found] <fa.h4eq5gb.nj6q31@ifi.uio.no>
[not found] ` <fa.gi5j8pu.92umbq@ifi.uio.no>
2004-05-14 0:50 ` 2.6.6-mm2 Andy Lutomirski
2004-05-14 1:01 ` 2.6.6-mm2 Chris Wright
2004-05-13 19:14 2.6.6-mm2 Martin J. Bligh
2004-05-13 19:21 ` 2.6.6-mm2 Andrew Morton
2004-05-13 20:47 ` 2.6.6-mm2 Adrian Bunk
2004-05-13 15:44 2.6.6-mm2 David Brownell
2004-05-13 10:27 2.6.6-mm2 Andrew Morton
2004-05-13 10:45 ` 2.6.6-mm2 Christoph Hellwig
2004-05-13 10:51 ` 2.6.6-mm2 Andrew Morton
2004-05-13 11:12 ` 2.6.6-mm2 Christoph Hellwig
2004-05-13 11:25 ` 2.6.6-mm2 Andrew Morton
2004-05-13 13:18 ` 2.6.6-mm2 Adrian Bunk
2004-05-13 13:39 ` 2.6.6-mm2 Chris Mason
2004-05-13 14:09 ` 2.6.6-mm2 Adrian Bunk
2004-05-17 20:52 ` 2.6.6-mm2 Bill Davidsen
2004-05-14 7:30 ` 2.6.6-mm2 Ian Kent
2004-05-13 14:15 ` 2.6.6-mm2 Adrian Bunk
2004-05-13 19:18 ` 2.6.6-mm2 Chris Wright
2004-05-13 19:29 ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:35 ` 2.6.6-mm2 Chris Wright
2004-05-13 19:38 ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:42 ` 2.6.6-mm2 Chris Wright
2004-05-14 19:14 ` 2.6.6-mm2 Andrea Arcangeli
2004-05-14 20:58 ` 2.6.6-mm2 Chris Wright
2004-05-15 2:43 ` 2.6.6-mm2 Andrea Arcangeli
2004-05-15 7:43 ` 2.6.6-mm2 Hugh Dickins
2004-05-14 19:06 ` 2.6.6-mm2 Kevin O'Connor
2004-05-14 19:36 ` 2.6.6-mm2 Chris Wright
2004-05-14 19:42 ` 2.6.6-mm2 Kevin O'Connor
2004-05-13 12:14 ` 2.6.6-mm2 Matt H.
2004-05-13 18:24 ` 2.6.6-mm2 Andrew Morton
2004-05-13 22:40 ` 2.6.6-mm2 Greg KH
2004-05-13 13:42 ` 2.6.6-mm2 Paolo Ornati
2004-05-13 15:07 ` 2.6.6-mm2 Lorenzo Allegrucci
2004-05-13 18:55 ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:41 ` 2.6.6-mm2 Lorenzo Allegrucci
2004-05-14 17:48 ` 2.6.6-mm2 R. J. Wysocki
2004-05-14 17:47 ` 2.6.6-mm2 Christoph Hellwig
2004-05-14 21:20 ` 2.6.6-mm2 R. J. Wysocki
2004-05-14 23:56 ` 2.6.6-mm2 Joseph Fannin
2004-05-14 23:58 ` 2.6.6-mm2 Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A40A0C.3070906@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.