All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Marc Singer <elf@buici.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][DOC] writing IDE driver guidelines
Date: Sat, 15 May 2004 18:23:04 -0400	[thread overview]
Message-ID: <40A69848.9020304@pobox.com> (raw)
In-Reply-To: <200405151958.03322.bzolnier@elka.pw.edu.pl>

Bartlomiej Zolnierkiewicz wrote:
> On Saturday 15 of May 2004 19:34, Jeff Garzik wrote:
>>On Sat, May 15, 2004 at 07:23:50PM +0200, Bartlomiej Zolnierkiewicz wrote:
>>>- host drivers should request/release IO resource
>>>  themelves and set hwif->mmio to 2
>>
>>Don't you mean, hwif->mmio==2 for MMIO hardware?
> 
> 
> It is was historically for MMIO, now it means that driver
> handles IO resource itself (per comment in <linux/ide.h>).

Maybe then create a constant HOST_IO_RESOURCES (value==2) to make that 
more obvious?


>>>- define ide_default_irq(), ide_init_default_irq()
>>>  and ide_default_io_base() to (0)
>>
>>Maybe provide generic definitions, so that new arches don't even
>>have to care about this?
> 
> 
> Please explain.

Your document appears to imply that each new arch should define the 
above three symbols.

My suggestion is to devise a method by which new arches don't have to 
care about those symbols at all, unless required to do so by the 
underlying hardware.

	Jeff




  parent reply	other threads:[~2004-05-15 22:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-15 17:23 [RFC][DOC] writing IDE driver guidelines Bartlomiej Zolnierkiewicz
2004-05-15 17:34 ` Jeff Garzik
2004-05-15 17:58   ` Bartlomiej Zolnierkiewicz
2004-05-15 18:13     ` Bartlomiej Zolnierkiewicz
2004-05-15 22:23     ` Jeff Garzik [this message]
2004-05-16  1:00       ` Marc Singer
2004-05-16 19:34         ` Bartlomiej Zolnierkiewicz
2004-05-16 19:26       ` Bartlomiej Zolnierkiewicz
2004-05-16  0:51     ` Marc Singer
2004-05-16 19:33       ` Bartlomiej Zolnierkiewicz
2004-06-05 19:49 ` Marc Singer
2004-06-05 20:36   ` Bartlomiej Zolnierkiewicz
2004-06-05 22:13     ` Marc Singer
2004-06-05 22:37       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A69848.9020304@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=elf@buici.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.