From: matthieu castet <castet.matthieu@free.fr>
To: linux-kernel@vger.kernel.org
Subject: [patch] bug in cpuid & msr on nosmp machine
Date: Wed, 19 May 2004 18:35:43 +0200 [thread overview]
Message-ID: <40AB8CDF.8060408@free.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
hi,
on monocpu machine (and maybe even on smp machine), when you try to
acces to a cpu that don't exist (/dev/cpu/1/cpuid), cpuid (msr) call
cpu_online, but on nosmp machine if the cpu!=0 this procude a BUG();
So I add a check that verify if the cpu can exist before calling cpu_online.
Matthieu CASTET
[-- Attachment #2: cpuid.patch --]
[-- Type: text/x-patch, Size: 454 bytes --]
--- linux/arch/i386/kernel/cpuid.c 2004-05-18 20:47:05.000000000 +0200
+++ linux-2.6.5/arch/i386/kernel/cpuid.c 2004-04-04 05:36:12.000000000 +0200
@@ -135,7 +135,7 @@
int cpu = iminor(file->f_dentry->d_inode);
struct cpuinfo_x86 *c = &(cpu_data)[cpu];
- if (cpu >= num_possible_cpus() || !cpu_online(cpu))
+ if (!cpu_online(cpu))
return -ENXIO; /* No such CPU */
if ( c->cpuid_level < 0 )
return -EIO; /* CPUID not supported */
[-- Attachment #3: msr.patch --]
[-- Type: text/x-patch, Size: 460 bytes --]
--- linux/arch/i386/kernel/msr.c 2004-05-19 18:25:09.000000000 +0200
+++ linux-2.6.5/arch/i386/kernel/msr.c 2004-04-04 05:36:57.000000000 +0200
@@ -241,7 +241,7 @@
int cpu = iminor(file->f_dentry->d_inode);
struct cpuinfo_x86 *c = &(cpu_data)[cpu];
- if (cpu >= num_possible_cpus() || !cpu_online(cpu))
+ if (!cpu_online(cpu))
return -ENXIO; /* No such CPU */
if ( !cpu_has(c, X86_FEATURE_MSR) )
return -EIO; /* MSR not supported */
next reply other threads:[~2004-05-19 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-19 16:35 matthieu castet [this message]
2004-05-19 17:46 ` [patch] bug in cpuid & msr on nosmp machine matthieu castet
2004-05-20 2:44 ` Jeff Sipek
2004-05-20 9:51 ` Paul Jackson
2004-05-20 7:32 ` Andrew Morton
2004-05-20 8:34 ` Rusty Russell
2004-05-20 8:51 ` Andrew Morton
2004-05-20 9:30 ` Rusty Russell
2004-05-20 9:57 ` Rusty Russell
[not found] <1XCh4-1jO-67@gated-at.bofh.it>
[not found] ` <1XRg3-4LW-31@gated-at.bofh.it>
[not found] ` <1XRg3-4LW-29@gated-at.bofh.it>
[not found] ` <1XSc3-5y3-23@gated-at.bofh.it>
2004-05-22 8:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40AB8CDF.8060408@free.fr \
--to=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.