From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] for some issues in tcp window tracking patch Date: Fri, 21 May 2004 18:07:05 +0200 Sender: netfilter-devel-admin@lists.netfilter.org Message-ID: <40AE2929.4040408@trash.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Pablo Neira , Jozsef Kadlecsik , Netfilter Development Mailinglist Return-path: To: Henrik Nordstrom In-Reply-To: Errors-To: netfilter-devel-admin@lists.netfilter.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: netfilter-devel.vger.kernel.org Henrik Nordstrom wrote: > On Fri, 21 May 2004, Patrick McHardy wrote: > > >>It should be, on x86 set_bit locks the bus: > > > Which was my second question.. does this set_bit really need to be atomic > with a memory barrier? I missed that question. It's probably not neccessary, we will get a small race when zapping conntracks, but according to this comment in unreplied() we already have one anyway. /* There's a small race here where we may free a just-assured connection. Too bad: we're in trouble anyway. */ Not sure if it's still correct, though. Regards Patrick PS: As it turns out, I won't be gone over the weekend like I wrote.