From: Jeff Garzik <jgarzik@pobox.com>
To: Arthur Othieno <a.othieno@bluewin.ch>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()
Date: Fri, 21 May 2004 16:04:44 -0400 [thread overview]
Message-ID: <40AE60DC.5030104@pobox.com> (raw)
In-Reply-To: <20040521195934.GA17681@mars>
Arthur Othieno wrote:
> Hi,
>
> We're prematurely pampering the request queue before
> checking whether it was indeed allocated successfully.
>
> Against 2.6.6. Thanks.
>
>
> floppy.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/block/floppy.c 2004-05-20 23:48:04.000000000 +0200
> +++ b/drivers/block/floppy.c 2004-05-21 21:29:33.000000000 +0200
> @@ -4271,11 +4271,11 @@
> goto out;
>
> floppy_queue = blk_init_queue(do_fd_request, &floppy_lock);
> - blk_queue_max_sectors(floppy_queue, 64);
> if (!floppy_queue) {
> err = -ENOMEM;
> goto fail_queue;
> }
> + blk_queue_max_sectors(floppy_queue, 64);
Good catch...
Jeff
next prev parent reply other threads:[~2004-05-21 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-21 19:59 [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors() Arthur Othieno
2004-05-21 20:04 ` Jeff Garzik [this message]
2004-05-21 20:10 ` Zwane Mwaikambo
2004-05-21 20:33 ` Luiz Fernando N. Capitulino
2004-05-21 20:51 ` Arthur Othieno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40AE60DC.5030104@pobox.com \
--to=jgarzik@pobox.com \
--cc=a.othieno@bluewin.ch \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.