All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Franco <stratus@acm.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH] request_region() on sound/oss/wavfront.c.
Date: Sat, 22 May 2004 21:54:57 +0000	[thread overview]
Message-ID: <40AFCC31.3050206@acm.org> (raw)

Hi list,

[Patch aplied against 2.6.6-bk9 - compiles cleanly. ]

I've added two error checks for request_region() calls on the source
and replaced a check_region() with request_region().The release_region()
calls seems to be ok, but let me known if i'm missing something.

Comments?

Hope that helps,
--
Gustavo Franco

--- sound/oss/wavfront.c.orig     2004-05-22 18:19:03.000000000 -0300
+++ sound/oss/wavfront.c  2004-05-22 18:28:38.000000000 -0300
@@ -2424,7 +2424,7 @@
           consumes 16.
        */
                                                                                                     

-       if (check_region (io_base, 16)) {
+       if (!request_region (io_base, 16, "wavefront")) {
                printk (KERN_ERR LOGNAME "IO address range 0x%x - 0x%x "
                        "already in use - ignored\n", dev.base,
                        dev.base+15);
@@ -2820,10 +2820,18 @@
                return -1;
        }
                                                                                                     

-       request_region (dev.base+2, 6, "wavefront synth");
+       if(!request_region (dev.base+2, 6, "wavefront synth")) {
+               printk (KERN_ERR LOGNAME "IO address range 0x%x - 0x%x "
+                                       "already in use\n", dev.base+2,
+                                       dev.base+7);
+       }
                                                                                                     

        if (dev.has_fx) {
-               request_region (dev.base+8, 8, "wavefront fx");
+               if(!request_region (dev.base+8, 8, "wavefront fx")) {
+                       printk (KERN_ERR LOGNAME "IO address range 0x%x -"
+                                       "0x%x already in use\n", dev.base+8,
+                                       dev.base+15);
+               }
        }
                                                                                                     

        if (wavefront_config_midi ()) {

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2004-05-22 21:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-22 21:54 Gustavo Franco [this message]
2004-05-24 18:44 ` [Kernel-janitors] [PATCH] request_region() on Luiz Fernando N. Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40AFCC31.3050206@acm.org \
    --to=stratus@acm.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.