From: Patrick McHardy <kaber@trash.net>
To: Martin Josefsson <gandalf@wlug.westbo.se>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Philip Craig <philipc@snapgear.com>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Netfilter-devel <netfilter-devel@lists.netfilter.org>
Subject: Re: [RFC] Die to NOTRACK/TRACE, long live MARK!
Date: Sun, 23 May 2004 19:00:49 +0200 [thread overview]
Message-ID: <40B0D8C1.6040209@trash.net> (raw)
In-Reply-To: <1085302540.969.51.camel@tux.rsn.bth.se>
Martin Josefsson wrote:
> Nice, I hope you succeed. We also need to rearrange struct ip_conntrack
> so often updated fields aren't sharing the same cacheline as mostly read
> fields. That and adding more test_bit() before we set_bit() (or
> something similar) will bring down the cache-trashing we have right now,
> especially on SMP.
I will make a test_bit patch on top of my memsave-patches (which are
on top of Joszef's conntrack patches). When we rearrange struct
ip_conntrack we should also try to get rid of the holes in the
structure, which are responsible for approximately 20bytes of wasted
memory.
Regards
Patrick
next prev parent reply other threads:[~2004-05-23 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-19 21:30 [RFC] Die to NOTRACK/TRACE, long live MARK! Jozsef Kadlecsik
2004-05-20 10:48 ` Pablo Neira
2004-05-21 0:20 ` Philip Craig
2004-05-21 2:12 ` Patrick McHardy
2004-05-22 12:38 ` Jozsef Kadlecsik
2004-05-22 14:57 ` Patrick McHardy
2004-05-23 8:55 ` Martin Josefsson
2004-05-23 17:00 ` Patrick McHardy [this message]
2004-05-25 12:38 ` Pablo Neira
2004-05-25 17:45 ` Patrick McHardy
2004-05-27 10:33 ` Henrik Nordstrom
2004-05-28 11:41 ` Pablo Neira
2004-05-21 12:35 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40B0D8C1.6040209@trash.net \
--to=kaber@trash.net \
--cc=gandalf@wlug.westbo.se \
--cc=kadlec@blackhole.kfki.hu \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=philipc@snapgear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.