From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34)
	id 1BTBnT-00075U-SG
	for qemu-devel@nongnu.org; Wed, 26 May 2004 23:43:12 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34)
	id 1BT4kq-0006AZ-WD
	for qemu-devel@nongnu.org; Wed, 26 May 2004 16:12:32 -0400
Received: from [193.252.22.29] (helo=mwinf0201.wanadoo.fr)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1BT4bf-0003ri-H1
	for qemu-devel@nongnu.org; Wed, 26 May 2004 16:02:31 -0400
Received: from bellard.org (ATuileries-112-1-3-7.w81-48.abo.wanadoo.fr
	[81.48.134.7])
	by mwinf0201.wanadoo.fr (SMTP Server) with ESMTP id 9A3B33000D81
	for <qemu-devel@nongnu.org>; Wed, 26 May 2004 22:02:30 +0200 (CEST)
Message-ID: <40B4F861.7000504@bellard.org>
Date: Wed, 26 May 2004 22:04:49 +0200
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] QEMU crash with Fedora Core 2
References: <200405260147.48047.hetz@witch.dyndns.org>
	<1085562014.3456.1171.camel@hades.cambridge.redhat.com>
In-Reply-To: <1085562014.3456.1171.camel@hades.cambridge.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

I cannot accept this patch: it breaks qemu-fast with all old libcs. The 
good solution is to use a specific sigaction call which directly makes 
the sigaction Linux system call.

Fabrice.

David Woodhouse wrote:
> On Wed, 2004-05-26 at 01:47 +0300, Hetz Ben Hamo wrote:
> 
>>qemu: relocation error: qemu: symbol __libc_sigaction, version GLIBC_PRIVATE 
>>not defined in file libc.so.6 with link time reference
>>
>>Googling this error brings a link to a redhat 7.3 bug ;)
> 
> 
> __libc_sigaction is a glibc private function. Explicitly linking to it
> is an application bug. 
> 
> I believe it's done to work around an old linuxthreads-related SDL bug
> which doesn't actually exist any more.
> 
> --- qemu-0.5.4/vl.c.orig	2004-05-02 11:58:59.852195291 +0100
> +++ qemu-0.5.4/vl.c	2004-05-02 11:59:37.856959391 +0100
> @@ -56,18 +56,6 @@
>  #define memalign(align, size) malloc(size)
>  #endif
>  
> -#ifdef CONFIG_SDL
> -/* SDL use the pthreads and they modify sigaction. We don't
> -   want that. */
> -#if __GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 2)
> -extern void __libc_sigaction();
> -#define sigaction(sig, act, oact) __libc_sigaction(sig, act, oact)
> -#else
> -extern void __sigaction();
> -#define sigaction(sig, act, oact) __sigaction(sig, act, oact)
> -#endif
> -#endif /* CONFIG_SDL */
> -
>  #include "disas.h"
>  
>  #include "exec-all.h"
> 
>