Re: Broken-up patch #12

[David Given <dg@cowlark.com>]

claudio@conectiva.com wrote:
[...]
> -               if (c == '^V')
> +               if (c == '^V ')
> 
> It seems that this patch is doing funny things with the ^V character
> (changing it to a space, adding a space after it). Is it really what
> it is supposed to do, even if commenting the code chunk out?

That ^V scares me. Please tell me it's not a literal control character 
in the actual source file. That would be very, very evil.

The alternative --- '^V' as four bytes --- is nearly as bad, because 
that's a multicharacter constant that will show up either as a 16-bit 
constant or an error message, neither of which will work. If it's 
showing up as ASCII char 22, that is also evil, because your C compiler 
shouldn't be doing that.

-- 
[insert interesting .sig here]