Hi Jozsef,

Jozsef Kadlecsik wrote:

>>- use of defined flags in tcp.h
>>    
>>
>
>As Patrick reminded us, we cannot use the TCPCB_FLAG_* flags. And I'm
>reluctant to use the enumerated values from include/linux/tcp.h because
>then I should have to add shifts to the window tracking code - just to
>eliminate the locally defined flags. What'd we gain by complicating the
>code?
>  
>

nothing, I agree with you and Patrick.

>>and pending that you give your ok:
>>- fine grain locking for private tcp helper info
>>    
>>
>
>First I added your code to the patch then removed it, sorry: it's overkill
>to add per entry locking. In the (near) future we'll have per bucket
>locking and then we can rely on that instead of a global tcp_lock.
>  
>

I agree, it doesn't make much sense adding that now, but it will after 
pushing forward your patches to improve locking stuff in conntrack.

Jozsef, I attached a patch to this email to clean up the way we handle 
trimmed off FIN packets, let me know if it's worth it. Still one 
question, should we update the timeout in this case?

regards,
Pablo