From: Jeff Garzik <jgarzik@pobox.com>
To: Adam Radford <aradford@amcc.com>
Cc: akpm@osdl.org, james.bottomley@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] 3ware 9000 driver update for 2.6.7-rc2-mm2
Date: Wed, 02 Jun 2004 18:53:36 -0400 [thread overview]
Message-ID: <40BE5A70.80500@pobox.com> (raw)
In-Reply-To: <HYPD6V00.Q4O@hadar.amcc.com>
Adam Radford wrote:
> Andrew, James,
>
> This patch updates the 3w-9xxx driver in 2.6.7-rc2-mm1 to v2.26.02.000 to cleanup several things pointed out by Chris Hellwig / Jeff Garzik.
Looks good, one major and one minor grumble remain:
Minor: Your schedule_timeout() usage is incorrect without also
set_current_state() and a loop in certain situations. However, the fix
is quite easy: just use the new msleep() function. In your code, it
should be a straight replacement from the mdelay() calls.
Major: code still wastes time caring about queue depth when it need
not. Don't emulate this feature, export the feature as the hardware
does -- using a controller-wide queue count, not per-device. This would
involve deleting the queue depth code and setting ->use_sg to 253, IIRC.
Jeff
next prev parent reply other threads:[~2004-06-02 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 22:29 [PATCH] 3ware 9000 driver update for 2.6.7-rc2-mm2 Adam Radford
2004-06-02 22:53 ` Jeff Garzik [this message]
2004-06-04 0:45 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2004-06-02 23:21 Adam Radford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40BE5A70.80500@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=aradford@amcc.com \
--cc=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.