All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Hanna Linder <hannal@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH 2.6.6-rc2 RFT] Add's class support to cpuid.c
Date: Wed, 02 Jun 2004 17:11:21 -0700	[thread overview]
Message-ID: <40BE6CA9.9030403@zytor.com> (raw)
In-Reply-To: <98460000.1086215543@dyn318071bld.beaverton.ibm.com>

Hanna Linder wrote:
> This patch adds class support to arch/i386/kernel/cpuid.c. This enables udev
> support. I have tested on a 2-way SMP system and on a 2-way built as UP.
> Here are the results for the SMP:

I think it would be better if udev could handle /dev/cpu as an iterator 
instead of needing O(N) kernel memory for all per-CPU devices; I made the same 
comments about devfs.

As it is, it also mishandles the hotswap CPU scenario.

> [hlinder@w-hlinder2 hlinder]$ tree /sys/class/cpuid
> /sys/class/cpuid
> |-- cpu0
> |   `-- dev
> `-- cpu1
>     `-- dev
> 
> 2 directories, 2 files
> [hlinder@w-hlinder2 hlinder]$ more /sys/class/cpuid/cpu0/dev
> 203:0
> [hlinder@w-hlinder2 hlinder]$ more /sys/class/cpuid/cpu1/dev
> 203:1
> [hlinder@w-hlinder2 hlinder]$

	-hpa

  reply	other threads:[~2004-06-03  0:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-02 22:32 [PATCH 2.6.6-rc2 RFT] Add's class support to cpuid.c Hanna Linder
2004-06-03  0:11 ` H. Peter Anvin [this message]
2004-06-03 19:32   ` Greg KH
2004-06-03 20:42     ` Hanna Linder
2004-06-08 21:10     ` Hanna Linder
2004-06-08 22:15       ` Hanna Linder
2004-06-08 23:26         ` Greg KH
2004-06-09  2:52         ` Zwane Mwaikambo
2004-06-09  5:45           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40BE6CA9.9030403@zytor.com \
    --to=hpa@zytor.com \
    --cc=greg@kroah.com \
    --cc=hannal@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.